improve strict openai compliance #1165
Conversation
![matter-code-review[bot]](https://avatars.githubusercontent.com/in/474549?s=60&v=4){kind=small}
|
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use Matter AICommand List
|
|
DescriptionSummary By MatterAI
🔄 What ChangedThis pull request introduces a new mechanism to improve strict OpenAI compliance, specifically for the 🔍 Impact of the ChangeThis change ensures that the 📁 Total Files Changed7 files were changed in this pull request:
🧪 Test AddedNo specific tests were explicitly mentioned or added in the provided pull request data. The changes primarily involve type definitions and a mapping function, which would ideally be covered by unit tests to ensure correct transformations for all defined stop reasons and edge cases. 🔒Security VulnerabilitiesNo new security vulnerabilities were detected in this pull request. The changes are focused on API response transformation and type safety, which do not introduce direct security risks. MotivationTo improve strict OpenAI compliance by standardizing the Type of Change
How Has This Been Tested?
Screenshots (if applicable)N/A Checklist
Related IssuesN/A Tip Quality Recommendations
Sequence DiagramsequenceDiagram
participant PR as Pull Request
participant AnthropicChatComplete as Anthropic Chat Completion
participant BedrockChatComplete as Bedrock Chat Completion
participant Utils as src/providers/utils.ts
participant FinishReasonMap as src/providers/utils/finishReasonMap.ts
PR->AnthropicChatComplete: Modify AnthropicChatCompleteResponse/StreamResponse
PR->BedrockChatComplete: Modify BedrockChatCompletionResponse/StreamChunk
PR->AnthropicChatComplete: Import transformFinishReason
PR->BedrockChatComplete: Import transformFinishReason
AnthropicChatComplete->Utils: Call transformFinishReason(response.stop_reason, strictOpenAiCompliance)
BedrockChatComplete->Utils: Call transformFinishReason(response.stopReason, strictOpenAiCompliance)
Utils->FinishReasonMap: Lookup finishReasonMap.get(providerFinishReason)
alt strictOpenAiCompliance is true
FinishReasonMap-->Utils: Return mapped FINISH_REASON (e.g., 'stop', 'length', 'tool_calls')
else strictOpenAiCompliance is false
FinishReasonMap-->Utils: Return original PROVIDER_FINISH_REASON
end
Utils-->AnthropicChatComplete: Return transformed finish_reason
Utils-->BedrockChatComplete: Return transformed finish_reason
AnthropicChatComplete->AnthropicChatComplete: Assign transformed finish_reason to OpenAI-compatible response
BedrockChatComplete->BedrockChatComplete: Assign transformed finish_reason to OpenAI-compatible response
Note over PR,FinishReasonMap: New enums ANTHROPIC_STOP_REASON, BEDROCK_STOP_REASON, FINISH_REASON, PROVIDER_FINISH_REASON defined in types.ts
Note over PR,FinishReasonMap: finishReasonMap.ts created for explicit mapping
|
|
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use Matter AICommand List
|
|
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use Matter AICommand List
|
|
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use Matter AICommand List
|
|
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use Matter AICommand List
|
|
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use Matter AICommand List
|
|
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use Matter AICommand List
|
|
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use Matter AICommand List
|
3 participants
this only fixes the finish reason for anthropic and bedrock converse for chat completions, need to add it slowly for every provider