Skip to content

Conversation

@b4s36t4
Copy link
Contributor

@b4s36t4 b4s36t4 commented Apr 9, 2025

Code Quality new feature

Author Description

(optional)

  • Detailed change 1
  • Detailed change 2

Title: feat: update azure foundry provider

🔄 What Changed

  • Updated Azure AI Inference provider to support Azure Foundry URL
  • Removed deprecated parameters (azureRegion, azureDeploymentType)
  • Implemented multiple authentication methods (API key, Entra ID, Managed Identity)
  • Improved API version handling in endpoint construction

🔍 Impact of the Change

  • Enhanced flexibility for Azure AI Inference integration
  • Improved security with multiple authentication options
  • Simplified URL construction with better parameter handling
  • Removed deprecated parameters for better maintainability

📁 Total Files Changed

  • 3 files modified (handlerUtils.ts, api.ts, requestBody.ts)
  • 58 lines added, 28 lines removed

🧪 Test Added

N/A - No tests were added in this PR

🔒 Security Vulnerabilities

No security vulnerabilities detected. The PR improves security by supporting more secure authentication methods.

Quality Recommendations

  1. Add unit tests to verify the new authentication methods work correctly

  2. Add error handling for failed token acquisition in the authentication methods

  3. Consider adding documentation comments to explain the different authentication modes

  4. Add validation for the azureFoundryUrl parameter to ensure it's properly formatted

@b4s36t4
Copy link
Contributor Author

b4s36t4 commented Apr 9, 2025

/matter review

@matter-code-review
Copy link
Contributor

I'm reviewing this PR now. I'll provide feedback shortly.

@matter-code-review
Copy link
Contributor

I encountered an error while trying to review this PR. Please try again later.

@VisargD VisargD merged commit 4597816 into Portkey-AI:main Apr 12, 2025
1 check passed
@b4s36t4
Copy link
Contributor Author

b4s36t4 commented Apr 22, 2025

Ref: #920

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants