fix: handle model check for finetune/batches #1020
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Author Description
🔄 What Changed
BEDROCK_NO_MODEL_ENDPOINTS
that lists all endpoints that don't require model validation🔍 Impact of the Change
📁 Total Files Changed
🧪 Test Added
🔒 Security Vulnerabilities
Title:
Description:
🔄 What Changed
BEDROCK_NO_MODEL_ENDPOINTS
that lists all endpoints that don't require model validation (listFinetunes
,retrieveFinetune
,cancelFinetune
,listBatches
,retrieveBatch
,getBatchOutput
,cancelBatch
).src/providers/bedrock/api.ts
to skip the check for endpoints present in theBEDROCK_NO_MODEL_ENDPOINTS
list.🔍 Impact of the Change
📁 Total Files Changed
src/providers/bedrock/api.ts
) with 12 additions and 1 deletion.🧪 Test Added
🔒 Security Vulnerabilities
Motivation:
Related Issues:
Quality Recommendations
Consider adding unit tests to verify the model validation logic for both endpoints requiring a model and those included in the
BEDROCK_NO_MODEL_ENDPOINTS
list. This will prevent regressions in the future.For improved lookup performance, especially if the list of endpoints might grow, consider using a
Set
instead of anArray
forBEDROCK_NO_MODEL_ENDPOINTS
.