Skip to content

Conversation

@narengogi
Copy link
Collaborator

@narengogi narengogi commented Mar 24, 2025

Code Quality ![bug detected](https://img.shields.io/badge/bug detected-d47f00)

Title:

  • Brief Description of Changes

Description:

🔄 What Changed

This Pull Request reverts previous changes made to the anthropic and bedrock chat completion files. The changes primarily involve removing the handling of 'thinking' and 'signature' properties from the response objects, which were previously included for compliance with OpenAI standards.

🔍 Impact of the Change

The removal of these properties may affect the functionality of the chat completion responses, particularly in how reasoning content is processed and returned. This could lead to a loss of information that was previously available to the users, potentially impacting user experience and the overall effectiveness of the chat service.

📁 Total Files Changed

2 files were modified:

  • src/providers/anthropic/chatComplete.ts
  • src/providers/bedrock/chatComplete.ts

🧪 Test Added

Tested with anthropic models to ensure that the chat completion functionality remains intact after the revert.

🔒 Security Vulnerabilities

No new security vulnerabilities were introduced in this change. However, the removal of certain properties could lead to unintended consequences if the application relies on them for security checks.

@narengogi narengogi marked this pull request as ready for review March 24, 2025 10:11
@narengogi narengogi requested a review from VisargD March 24, 2025 10:12
@narengogi narengogi changed the title revert changes made for anthropic thinking Feature: Changes for anthropic thinking Mar 24, 2025
@narengogi narengogi requested a review from VisargD March 24, 2025 20:38
@VisargD VisargD merged commit d15542a into Portkey-AI:main Mar 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants