-
Notifications
You must be signed in to change notification settings - Fork 771
Feature: Changes for anthropic thinking #1001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
VisargD
merged 5 commits into
Portkey-AI:main
from
narengogi:fix/revert-anthropic-thinking-support
Mar 25, 2025
Merged
Feature: Changes for anthropic thinking #1001
VisargD
merged 5 commits into
Portkey-AI:main
from
narengogi:fix/revert-anthropic-thinking-support
Mar 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VisargD
reviewed
Mar 24, 2025
VisargD
reviewed
Mar 24, 2025
VisargD
reviewed
Mar 24, 2025
VisargD
reviewed
Mar 24, 2025
VisargD
reviewed
Mar 24, 2025
VisargD
approved these changes
Mar 24, 2025
VisargD
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title:
Description:
🔄 What Changed
This Pull Request reverts previous changes made to the
anthropicandbedrockchat completion files. The changes primarily involve removing the handling of 'thinking' and 'signature' properties from the response objects, which were previously included for compliance with OpenAI standards.🔍 Impact of the Change
The removal of these properties may affect the functionality of the chat completion responses, particularly in how reasoning content is processed and returned. This could lead to a loss of information that was previously available to the users, potentially impacting user experience and the overall effectiveness of the chat service.
📁 Total Files Changed
2 files were modified:
src/providers/anthropic/chatComplete.tssrc/providers/bedrock/chatComplete.ts🧪 Test Added
Tested with anthropic models to ensure that the chat completion functionality remains intact after the revert.
🔒 Security Vulnerabilities
No new security vulnerabilities were introduced in this change. However, the removal of certain properties could lead to unintended consequences if the application relies on them for security checks.