Install mac dependencies using brew bundle, which properly handles already installed packages #583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGlustein
requested review from
alexddobkin,
ptomecek,
robambalu,
svatasoiu and
timkpaine
as code owners
alexddobkin
previously approved these changes
Aug 28, 2025
Member
|
Lets make sure to explicitly omit in https://github.com/Point72/csp/blob/fix-macos-14-builds/MANIFEST.in (this will be easier when we move to https://github.com/python-project-templates/hatch-cpp) |
Collaborator
Author
Done |
…ready installed packages Signed-off-by: Adam Glustein <[email protected]>
AdamGlustein
force-pushed
the
fix-macos-14-builds
branch
from
b7fe2f7 to
31a1d6e
Compare
alexddobkin
approved these changes
Aug 28, 2025
AdamGlustein
added a commit
that referenced
this pull request
Oct 8, 2025
…ready installed packages (#583) Signed-off-by: Adam Glustein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the MacOS build failure from today's scheduled CI run: https://github.com/Point72/csp/actions/runs/17290443368
It used to be that installing an already installed package using
brew install(from a different tap) would just raise a warning message like: https://github.com/Point72/csp/actions/runs/17121640880/job/48563694153#step:8:75But after this change in homebrew (there was a macos runner upgrade), it now raises an error (
odie) instead of a warning (onoe): Homebrew/brew#20304I found the recommended way of installing dependencies by the homebrew maintainer is to use
brew bundleinstead which does properly handle already-installed packages: Homebrew/brew#2491 (comment)Tested this out with a full build and verified that this approach does indeed skip already installed packages and avoid the error: https://github.com/Point72/csp/actions/runs/17300432139/job/49109830852#step:5:329