Use weak references for last context in pydantic validation #582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nijat Khanbabayev <[email protected]>
Signed-off-by: Nijat Khanbabayev <[email protected]>
NeejWeej
force-pushed
the
nk/weak_ref_context
branch
from
100b830 to
58f34fc
Compare
NeejWeej
requested review from
AdamGlustein,
alexddobkin,
robambalu and
svatasoiu
as code owners
ptomecek
approved these changes
Aug 20, 2025
AdamGlustein
approved these changes
Aug 20, 2025
AdamGlustein
pushed a commit
that referenced
this pull request
Oct 8, 2025
* Use weakref for previous context maintenance Signed-off-by: Nijat Khanbabayev <[email protected]> * Add test for TVarValidationContext garbage collection Signed-off-by: Nijat Khanbabayev <[email protected]> --------- Signed-off-by: Nijat Khanbabayev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We utilize a weakref to make sure that we do not maintain the last context when nothing else references it.