Toxiproxy support for Aerospike #826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnopnop
previously approved these changes
Mar 21, 2022
| properties = { | ||
| "embedded.aerospike.install.enabled=true", | ||
| "embedded.aerospike.toxiProxy.enabled=true", | ||
| "embedded.toxiproxy.enabled=true"//TODO: temporary |
Aloren
force-pushed
the
feature/toxi-proxy-part-2
branch
2 times, most recently
from
3b1bd39 to
c3ea1e3
Compare
Aloren
force-pushed
the
feature/toxi-proxy-part-2
branch
5 times, most recently
from
a200058 to
16a29f3
Compare
Aloren
changed the title
jnopnop
previously approved these changes
Mar 23, 2022
|
|
||
| @Bean | ||
| @Conditional(AerospikeToxiProxyProxyEnabled.class) | ||
| ToxiproxyContainer.ContainerProxy aerospikeContainerProxy(ToxiproxyContainer toxiproxyContainer, |
There was a problem hiding this comment.
I like this approach with external proxy so we're not tied to a single way of communicating with the container from the outside. Nice job @Aloren 👏
There was a problem hiding this comment.
thanks. I think, that separate properties for the proxy are more transparent for the end user.
Aloren
force-pushed
the
feature/toxi-proxy-part-2
branch
from
16a29f3 to
4055c95
Compare
Aloren
force-pushed
the
feature/toxi-proxy-part-2
branch
from
4055c95 to
0537388
Compare
|
looks like there is an incident with gh actions: https://www.githubstatus.com/incidents/y5hdmv0p49x3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.