Update memsql docker image to singlestore/cluster-in-a-box #808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijusti
force-pushed
the
feature/new-memsql
branch
from
a136d13 to
da914c4
Compare
Aloren
added
breaking-change
dependencies
|
Tests for the module failed. |
Aloren
reviewed
Feb 22, 2022
embedded-memsql/src/main/java/com/playtika/test/memsql/MemSqlProperties.java
Outdated
Show resolved
Hide resolved
ijusti
force-pushed
the
feature/new-memsql
branch
3 times, most recently
from
746ffa0 to
45504c6
Compare
Aloren
force-pushed
the
feature/new-memsql
branch
from
45504c6 to
550df91
Compare
Aloren
reviewed
Feb 22, 2022
...-memsql/src/test/java/com/playtika/test/memsql/EmbeddedMemSqlBootstrapConfigurationTest.java
Outdated
Show resolved
Hide resolved
Aloren
reviewed
Feb 22, 2022
...-memsql/src/test/java/com/playtika/test/memsql/EmbeddedMemSqlBootstrapConfigurationTest.java
Outdated
Show resolved
Hide resolved
Aloren
reviewed
Feb 22, 2022
embedded-memsql/README.adoc
Outdated
|
|
||
| ==== Notes | ||
|
|
||
| * Images without "minimal" tag do no start within 30 secs, so they are unusable |
There was a problem hiding this comment.
Are these notes still actual?
pls replace Network latency is currently do not work with NetworkTestOperations are not supported currently.
Also what is the reason it does not work anymore?
There was a problem hiding this comment.
Imposible to install ifconfig via yum into docker image
ijusti
force-pushed
the
feature/new-memsql
branch
3 times, most recently
from
7c9be0d to
43e51a3
Compare
Aloren
reviewed
Feb 23, 2022
| ) { | ||
| return new DefaultNetworkTestOperations(memsql); | ||
| } | ||
| // Current image doesn't support `tc` command, since kafka is currently based on ubi with microdnf package manager. `iproute2` package is not available here. |
There was a problem hiding this comment.
Current image doesn't support tc command, since kafka is currently based on ubi with microdnf package manager. iproute2 package is not available here.?
:)
ijusti
force-pushed
the
feature/new-memsql
branch
from
43e51a3 to
c34867a
Compare
Aloren
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.