Skip to content

DB2 containers #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 30, 2021
Merged

DB2 containers #719

merged 9 commits into from
Sep 30, 2021

Conversation

@IlyasYOY
Copy link
Contributor

I tried to implement issue #280

I'll be glad to receive your feedback! Thanks!

IlyasYOY
IlyasYOY commented Aug 17, 2021
View reviewed changes
embedded-db2/src/test/resources/container-license-acceptance.txt
@@ -0,0 +1 @@
ibmcom/db2:11.5.0.0a No newline at end of file
Copy link
Contributor Author

@IlyasYOY IlyasYOY Aug 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I remove this file? I must be here because of DB2 licensing
I don't how how to remove this, if I remove this then CI would fail

vasilievip
vasilievip suggested changes Aug 25, 2021
View reviewed changes
testcontainers-spring-boot-parent/pom.xml Outdated
<dependency>
<groupId>com.ibm.db2</groupId>
<artifactId>jcc</artifactId>
<version>11.5.0.0</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to property

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ✅
5d15b90

@IlyasYOY IlyasYOY changed the title WIP: DB2 containers DB2 containers Sep 9, 2021
@vasilievip
Copy link
Contributor

@IlyasYOY could you please check failure, I will merge pr once build passed

arturkandur
arturkandur reviewed Sep 10, 2021
View reviewed changes
embedded-db2/README.adoc Outdated
* `embedded.db2.acceptLicence` `(default is 'false')`
* `embedded.db2.startupLogCheckRegex`
* `embedded.db2.initScriptPath`
** Image versions on https://hub.docker.com/r/voltdb/voltdb-community/tags[dockerhub]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change url according your image version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't set specific version there.

Fixed CP mistake. Thanks!

@IlyasYOY
Copy link
Contributor Author

IlyasYOY commented Sep 14, 2021 •
edited
Loading

@IlyasYOY could you please check failure, I will merge pr once build passed

Checked localy

mvn install  -pl embedded-db2 -am

Got:

[INFO] Reactor Summary for com.playtika.testcontainers:testcontainers-spring-boot 2.0.15-SNAPSHOT:
[INFO] 
[INFO] com.playtika.testcontainers:testcontainers-spring-boot SUCCESS [  1.572 s]
[INFO] testcontainers-spring-boot-parent .................. SUCCESS [  0.421 s]
[INFO] testcontainers-common .............................. SUCCESS [ 37.075 s]
[INFO] embedded-db2 ....................................... SUCCESS [02:56 min]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  03:36 min
[INFO] Finished at: 2021-09-14T12:39:50+03:00
[INFO] ------------------------------------------------------------------------

I guess all problems were because I had conflicts with upstream branch.

@arturkandur
Copy link
Contributor

@IlyasYOY Please update your branch from 'develop'. Issue with failed build should be fixed.

@IlyasYOY
Copy link
Contributor Author

Hello @vasilievip

You still request changes. I updated my branch on new develop.

@vasilievip vasilievip merged commit b48e280 into PlaytikaOSS:develop Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@arturkandur arturkandur arturkandur left review comments

@vasilievip vasilievip vasilievip approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@IlyasYOY @vasilievip @arturkandur