Skip to content

Conversation

@roskh
Copy link
Contributor

@roskh roskh commented Jul 19, 2021

Implement consul as an exposable test container.

Allow specifying image to use, and configuration file which will be added to consul docker image (useful for testing consul API's ACL access tokens).

Implements #688

@roskh roskh changed the title WIP: Implement Consul test container Implement Consul test container Jul 19, 2021
@roskh roskh marked this pull request as ready for review July 19, 2021 18:25

==== Consumer (via `bootstrap.properties`)

* `embedded.redis.enabled` `(true|false, default is 'true')`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redis?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, renamed.

@roskh roskh requested a review from vasilievip August 2, 2021 11:51
@roskh
Copy link
Contributor Author

roskh commented Aug 2, 2021

It seems the CI is failing due to an unrelated module (I guess the develop branch CI also fails?)

image

@Aloren Aloren merged commit c69671a into PlaytikaOSS:develop Aug 3, 2021
@Aloren
Copy link
Contributor

Aloren commented Aug 3, 2021

@roskh thank you for the contribution!

@Aloren Aloren added the feature label Aug 3, 2021
IlyasYOY pushed a commit to IlyasYOY/testcontainers-spring-boot that referenced this pull request Aug 16, 2021
* implement simple consul server

* implement specifying consul config file

* add readme

* add consul tests

* cleanup code

* update README

Co-authored-by: Anastasiia Smirnova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants