Skip to content

Conversation

@sdobrovolschi
Copy link
Contributor

@sdobrovolschi sdobrovolschi commented Apr 22, 2025

Closes #2339

The reason to start a container from a Dockerfile is that Temporal CLI is the only way to start Temporal Server in development mode using an in-memory database.
The existing images expect a preconfigured database.

Copy link
Collaborator

@ijusti ijusti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution.
Is it possible to use one of this images https://hub.docker.com/search?q=temporal or publish image there. Note that it should be also compatible with ARM

@sdobrovolschi
Copy link
Contributor Author

Thanks for contribution. Is it possible to use one of this images https://hub.docker.com/search?q=temporal or publish image there. Note that it should be also compatible with ARM

The Temporal Service consists of four components. Although the official images support running all of them within a single container, none of them comes bundled with a database.
The Temporal CLI is the only official method for running Temporal in development mode.
Note that the shell script used in the Dockerfile to install the Temporal CLI accounts for both the platform and architecture.

The main concern with maintaining a custom image is that it can quickly become outdated.

What are the potential issues associated with spinning up a container from a Dockerfile?

@codecov
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.16%. Comparing base (5b7d5b4) to head (bb65870).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2340      +/-   ##
=============================================
+ Coverage      80.02%   80.16%   +0.14%     
- Complexity       664      671       +7     
=============================================
  Files            199      201       +2     
  Lines           3169     3202      +33     
  Branches         132      134       +2     
=============================================
+ Hits            2536     2567      +31     
- Misses           564      565       +1     
- Partials          69       70       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sdobrovolschi
Copy link
Contributor Author

Hey @ijusti , when you have a chance, I'd appreciate your thoughts on my comment above.

@ijusti
Copy link
Collaborator

ijusti commented May 5, 2025

Thanks for contribution. Is it possible to use one of this images hub.docker.com/search?q=temporal or publish image there. Note that it should be also compatible with ARM

The Temporal Service consists of four components. Although the official images support running all of them within a single container, none of them comes bundled with a database. The Temporal CLI is the only official method for running Temporal in development mode. Note that the shell script used in the Dockerfile to install the Temporal CLI accounts for both the platform and architecture.

The main concern with maintaining a custom image is that it can quickly become outdated.

What are the potential issues associated with spinning up a container from a Dockerfile?

Main concern associated with spinning up a container from a Dockerfile is that it will not be renovated, and it is not the common way it is done. It would be better to build an image and push it to the docker hub.
Or update renovate.json so it may be able to update latest versions.

ijusti
ijusti previously approved these changes May 5, 2025
@ijusti
Copy link
Collaborator

ijusti commented May 5, 2025

@sdobrovolschi
Copy link
Contributor Author

sdobrovolschi commented May 6, 2025

try please this https://hub.docker.com/r/keepsuit/temporalio-dev-server

Thank you @ijusti for the hint. It seems that the official temporalio/admin-tools image allows the Temporal Server to run in development mode with the overridden entrypoint.

I got rid of the Dockerfile. Could you please take a look at the PR once again?

ijusti
ijusti previously approved these changes May 7, 2025
@sdobrovolschi
Copy link
Contributor Author

sdobrovolschi commented May 7, 2025

@ijusti could you re-run the pipeline, please?

@ijusti ijusti merged commit a22248a into PlaytikaOSS:develop May 7, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Temporal

2 participants