-
Notifications
You must be signed in to change notification settings - Fork 244
Add support for Temporal (#2339) #2340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contribution.
Is it possible to use one of this images https://hub.docker.com/search?q=temporal or publish image there. Note that it should be also compatible with ARM
The Temporal Service consists of four components. Although the official images support running all of them within a single container, none of them comes bundled with a database. The main concern with maintaining a custom image is that it can quickly become outdated. What are the potential issues associated with spinning up a container from a Dockerfile? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2340 +/- ##
=============================================
+ Coverage 80.02% 80.16% +0.14%
- Complexity 664 671 +7
=============================================
Files 199 201 +2
Lines 3169 3202 +33
Branches 132 134 +2
=============================================
+ Hits 2536 2567 +31
- Misses 564 565 +1
- Partials 69 70 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey @ijusti , when you have a chance, I'd appreciate your thoughts on my comment above. |
Main concern associated with spinning up a container from a Dockerfile is that it will not be renovated, and it is not the common way it is done. It would be better to build an image and push it to the docker hub. |
|
try please this https://hub.docker.com/r/keepsuit/temporalio-dev-server |
Thank you @ijusti for the hint. It seems that the official temporalio/admin-tools image allows the Temporal Server to run in development mode with the overridden entrypoint. I got rid of the Dockerfile. Could you please take a look at the PR once again? |
embedded-temporal/src/main/java/com/playtika/testcontainer/temporal/TemporalProperties.java
Show resolved
Hide resolved
|
@ijusti could you re-run the pipeline, please? |
Closes #2339
The reason to start a container from a Dockerfile is that Temporal CLI is the only way to start Temporal Server in development mode using an in-memory database.
The existing images expect a preconfigured database.