switch off stop-writes-sys-memory-pct metric for aerosspike enterprise #1761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfchkov
force-pushed
the
feature/off-aerospike-enterprise-stop-writes-sys-memory-pct
branch
2 times, most recently
from
9297504 to
bff9fc4
Compare
matveym
reviewed
Feb 14, 2024
| } | ||
|
|
||
| private void switchOffStopWritesSysMemoryPctMetric(GenericContainer<?> aerospikeContainer) throws IOException, InterruptedException { | ||
| log.info("Switching off 'stop-writes-sys-memory-pct'..."); |
matveym
reviewed
Feb 14, 2024
| Container.ExecResult result = aerospikeContainer.execInContainer("asadm", "--enable", "-e", | ||
| String.format("manage config namespace %s param stop-writes-sys-memory-pct to 100", namespace)); | ||
| logStdout(result); | ||
| if (result.getExitCode() != 0) { |
There was a problem hiding this comment.
exit code check does not show much - let's try to match the correct output, if not - fail
matveym
reviewed
Feb 14, 2024
...stcontainers/aerospike/enterprise/ValidateEnterpriseAerospikeBootstrapConfigurationTest.java
Show resolved
Hide resolved
matveym
reviewed
Feb 14, 2024
| @Test | ||
| void skipValidation() { | ||
| contextRunner.withPropertyValues("embedded.aerospike.dockerImage=aerospike-server:6.1.0.16_1", | ||
| contextRunner.withPropertyValues("embedded.aerospike.dockerImage=aerospike-server:6.1.0.16", |
There was a problem hiding this comment.
it just checks version format, no matter
matveym
reviewed
Feb 14, 2024
| private void switchOffStopWritesSysMemoryPctMetric(GenericContainer<?> aerospikeContainer) throws IOException, InterruptedException { | ||
| log.info("Switching off 'stop-writes-sys-memory-pct'..."); | ||
| String namespace = aerospikeProperties.getNamespace(); | ||
| Container.ExecResult result = aerospikeContainer.execInContainer("asadm", "--enable", "-e", |
There was a problem hiding this comment.
extract common logic into method
wolfchkov
force-pushed
the
feature/off-aerospike-enterprise-stop-writes-sys-memory-pct
branch
from
bff9fc4 to
1e7df3b
Compare
matveym
reviewed
Feb 14, 2024
| Container.ExecResult result = aerospikeContainer.execInContainer("asadm", "--enable", "-e", command); | ||
| logStdout(result); | ||
| if (result.getExitCode() != 0 || isBadResponse(result)) { | ||
| throw new IllegalStateException(String.format("Failed to execute asadm --enable -e '%s': %s", command, result.getStderr())); |
There was a problem hiding this comment.
log both stdout & stderr.
I'd do like something like this:
String delimiter = "-".repeat(40); String.format("Failed to execute....'%s'\nStdout:%s%s%s\nStdErr:%s%s%s", command, delimiter, result.getStdout(), delimiter, delimiter, result.getStdErr(), delimiter)
matveym
approved these changes
Feb 14, 2024
wolfchkov
force-pushed
the
feature/off-aerospike-enterprise-stop-writes-sys-memory-pct
branch
from
1e7df3b to
df4ec00
Compare
Fameing
reviewed
Feb 14, 2024
| Documentation: https://aerospike.com/docs/server/reference/configuration#stop-writes-sys-memory-pct | ||
| */ | ||
| log.info("Switching off 'stop-writes-sys-memory-pct'... "); | ||
| asadmCommandExecutor.execute(String.format("manage config namespace %s param stop-writes-sys-memory-pct to 100", namespace)); |
There was a problem hiding this comment.
Why don't you check execute the result of the command?
There was a problem hiding this comment.
it is checked in AsadmCommandExecutor
|
|
||
| if (enterpriseProperties.isDurableDeletes()) { | ||
| log.info("Setting up 'disallow-expunge' to true..."); | ||
| asadmCommandExecutor.execute(String.format("manage config namespace %s param disallow-expunge to true", namespace)); |
There was a problem hiding this comment.
Why don't you check execute the result of the command?
There was a problem hiding this comment.
it is checked in AsadmCommandExecutor
Fameing
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.