Implemented feature to gray out all controls if they are disabled #59
Conversation
flabbet
left a comment
flabbet
left a comment
There was a problem hiding this comment.
The code looks like it should work, but I tried running ColorPickerDemo and changed IsEnabled=False on StandardColorPicker PortableColorPicker, but nothing grayed out. Is there something I am missing out?
|
Uhm I set IsEnabled=False on the MainWindow and then it worked for me. I tried that now again. But I will check it why this could not work. Edit: Ah ok, I think I know the issue. I updated the WPF controls but not the AvaloniaUI controls. I will fix and commit that. |
|
Ok, it was actually as I thought: I forgot to also implement this feature in the AvaloniaUI control. Now they also gray out if they are disabled. |
|
The issue is not related to Avalonia. I tested WPF demo project. Although thank you for implementing that too. My problem was that setting IsEnabled to individual controls do not make them grayed out. I did not test setting IsEnabled to whole window. I'll check if everything works with avalonia later |
|
Ahh ok. Then I will check that again if I missed something. |
|
Uhm I now tried it again with WPF and I was able to disable some of the controls (also tested with different .Net versions). So actually I am a bit confused, why it does not work for you. |
| </Setter> | ||
| </ControlTheme> | ||
|
|
||
| <!-- Style für disabled State: Graustufen-Bild verwenden --> |
There was a problem hiding this comment.
Please do not include comments in german
There was a problem hiding this comment.
Oh, my bad. Sorry, that I added this comment in german. I now removed it.
2 participants
The current color controls keep their state even if they are disabled. However, this can be confusing for users because there is no visual feedback that the controls are disabled. This PR changes this behavior by using the luminance of a color as the gray value.
Enabled Controls
Disabled Controls
Breaking Changes
This PR changes the visual behavior of the color controls so if developers used the disabled state to just display the color, this PR will break this. However, I would argue that the color controls are primarily to control the color values and not just to display them. If such a display option is needed, an additional "KeepColorWhileDisabled" DP could be added to the controls.