Avoid rebuilding the flattened canvas texture when the selection changes #1912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves performance significantly with larger images, especially for tools like Lasso Select which marked the entire canvas as being modified, and also with the animated selection outline which caused many continuous updates Instead of having the select tools use the canvas invalidation events, the canvas widget can just listen for selection change events from the document and update accordingly Bug: #1909
cameronwhite
added a commit
that referenced
this pull request
Jan 10, 2026
…ges (#1912) * Avoid rebuilding the flattened canvas texture when the selection changes This improves performance significantly with larger images, especially for tools like Lasso Select which marked the entire canvas as being modified, and also with the animated selection outline which caused many continuous updates Instead of having the select tools use the canvas invalidation events, the canvas widget can just listen for selection change events from the document and update accordingly * Cache the selection path for some minor performance improvement Bug: #1909 (cherry picked from commit 89a58be)
cameronwhite
added a commit
that referenced
this pull request
Jan 10, 2026
…ges (#1912) * Avoid rebuilding the flattened canvas texture when the selection changes This improves performance significantly with larger images, especially for tools like Lasso Select which marked the entire canvas as being modified, and also with the animated selection outline which caused many continuous updates Instead of having the select tools use the canvas invalidation events, the canvas widget can just listen for selection change events from the document and update accordingly * Cache the selection path for some minor performance improvement Bug: #1909 (cherry picked from commit 89a58be)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves performance significantly with larger images, especially for tools like Lasso Select which marked the entire canvas as being modified, and also with the animated selection outline which caused many continuous updates
Instead of having the select tools use the canvas invalidation events, the canvas widget can just listen for selection change events from the document and update accordingly
Bug: #1909