Skip to content
This repository was archived by the owner on Dec 26, 2022. It is now read-only.

🔥 Removing construct_client_dict by Fixing APIObject client attribute #360

Merged
merged 11 commits into from
Jan 9, 2022
Merged

🔥 Removing construct_client_dict by Fixing APIObject client attribute #360

merged 11 commits into from
Jan 9, 2022

Conversation

@Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Jan 9, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jan 9, 2022 •
edited
Loading

Codecov Report

Merging #360 (188ad1f) into main (7b240ae) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #360   +/-   ##
=======================================
  Coverage   90.54%   90.54%           
=======================================
  Files           8        8           
  Lines          74       74           
=======================================
  Hits           67       67           
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b240ae...188ad1f. Read the comment docs.

Enderchief
Enderchief suggested changes Jan 9, 2022
View reviewed changes
Copy link
Member

@Enderchief Enderchief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run black on the files changed. I can tell you did not

@Sigmanificient Sigmanificient linked an issue Jan 9, 2022 that may be closed by this pull request
🐛 APIObject require _client & _http everytime, leading to bugs #361
Closed
@Sigmanificient Sigmanificient added the enhancement New feature or request label Jan 9, 2022
@Sigmanificient
Copy link
Member Author

Sigmanificient commented Jan 9, 2022 •
edited
Loading

Please run black on the files changed. I can tell you did not

Are you sure you want me to run black on 72 files?

zunda-arrow
zunda-arrow suggested changes Jan 9, 2022
View reviewed changes
@Sigmanificient Sigmanificient merged commit f3226fe into main Jan 9, 2022
@Sigmanificient Sigmanificient deleted the APIObject-fix branch January 10, 2022 00:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

4 more reviewers

@Secrus Secrus Secrus left review comments

@Enderchief Enderchief Enderchief requested changes

@zunda-arrow zunda-arrow zunda-arrow requested changes

@trag1c trag1c trag1c approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐛 APIObject require _client & _http everytime, leading to bugs

6 participants

@Sigmanificient @Secrus @Enderchief @zunda-arrow @trag1c