🐛 ✨ Added VERY basic sharding support and fixed the gateway #329
Conversation
|
fixing gateway more like rewrite |
@VincentRPS Pincer somehow has a lot of technical debt 👐 |
|
@Lunarmagpie did you remove websockets from setup_config? |
|
the dependency has been removed |
Codecov Report
@@ Coverage Diff @@
## main #329 +/- ##
==========================================
+ Coverage 90.00% 90.54% +0.54%
==========================================
Files 9 8 -1
Lines 100 74 -26
==========================================
- Hits 90 67 -23
+ Misses 10 7 -3
Continue to review full report at Codecov.
|
| Returns | ||
| ------- | ||
| bool |
There was a problem hiding this comment.
I don't know if it's required but shouldn't it be :class:`bool` or sth like that?
There was a problem hiding this comment.
Its not required I think
Co-authored-by: trag1c <[email protected]>
Co-authored-by: trag1c <[email protected]>
Co-authored-by: trag1c <[email protected]>
Co-authored-by: trag1c <[email protected]>
Co-authored-by: trag1c <[email protected]>
Co-authored-by: trag1c <[email protected]>
Co-authored-by: Endercheif <[email protected]>
Co-authored-by: Endercheif <[email protected]>
| socket : :class:`~ws:websockets.legacy.client.WebSocketClientProtocol` | ||
| The current socket, which can be used to interact | ||
| with the Discord API. | ||
| def set_session_id(self, _id: str): |
There was a problem hiding this comment.
Thats a setter not a getter. I could make the variable public but I kept it private for consistency.
Co-authored-by: Yohann Boniface <[email protected]>
Co-authored-by: Endercheif <[email protected]>
5 participants
Changes
adds: Basic gateway. Shards. They are not started properly because I didn't understand that part of the docs.fixed: Middleware is updated with proper type hints.improvements: Gateway shouldn't disconnectThis needs to be reviewed. The gateway has some pretty awful code so I'm opening this now so I can get some suggestions
Check off the following