Skip to content

Conversation

RtgrV
Copy link
Contributor

@RtgrV RtgrV commented Jun 27, 2023

Issue report: #43

  • Upgraded packages and ran codegen
  • Added Connectable field in discovery data on Android and iOS
  • Updated iOS project files
Android iOS iOS detail
image Image from iOS Image from iOS (1)

@RtgrV RtgrV force-pushed the add-connectability-from-discovery-data branch from d98f290 to 863d915 Compare June 27, 2023 19:50
@RtgrV RtgrV force-pushed the add-connectability-from-discovery-data branch from 863d915 to ec3cf4d Compare June 27, 2023 20:01
@RtgrV RtgrV force-pushed the add-connectability-from-discovery-data branch 4 times, most recently from 22eb538 to a185890 Compare June 27, 2023 20:45
@RtgrV RtgrV force-pushed the add-connectability-from-discovery-data branch from a185890 to 46d42bd Compare June 27, 2023 20:53
Copy link
Collaborator

@werediver werediver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, check my remarks. Because they are not critical, I approve any way.

Thanks for contributing.

@Taym95 Taym95 merged commit ccc0298 into PhilipsHue:master Jun 28, 2023
Taym95 pushed a commit that referenced this pull request Jul 6, 2023
* Update dependencies, set ruby version and run codegen

* Add IsConnectable support for Android and iOS

* iOS Project updates

* Set melos to fixed version

* Add tests

* Keep bledata protos number in order

---------

Co-authored-by: RutgerVromans <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants