Skip to content

fix EnumTryAs to allow attributes on enum variant fields #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2025
Merged

fix EnumTryAs to allow attributes on enum variant fields #400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion strum_macros/src/macros/enum_try_as.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ pub fn enum_try_as_inner(ast: &DeriveInput) -> syn::Result<TokenStream> {
syn::Fields::Unnamed(values) => {
let variant_name = &variant.ident;
let types: Vec<_> = values.unnamed.iter().map(|field| {
field.to_token_stream()
field.ty.to_token_stream()
}).collect();
let field_names: Vec<_> = values.unnamed.iter().enumerate().map(|(i, _)| {
let name = "x".repeat(i + 1);
Expand Down
7 changes: 7 additions & 0 deletions strum_tests/tests/enum_try_as.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ enum Foo {
Unnamed0(),
Unnamed1(u128),
Unnamed2(bool, String),
Unnamed3(#[allow(deprecated)] u128),
#[strum(disabled)]
#[allow(dead_code)]
Disabled(u32),
Expand Down Expand Up @@ -35,6 +36,12 @@ fn unnamed_2() {
assert_eq!(Some((true, String::from("Hay"))), foo.try_as_unnamed_2());
}

#[test]
fn unnamed_3() {
let foo = Foo::Unnamed3(128);
assert_eq!(Some(&128), foo.try_as_unnamed_3_ref());
}

#[test]
fn can_mutate() {
let mut foo = Foo::Unnamed1(128);
Expand Down