Skip to content

Conversation

@bluurryy
Copy link
Contributor

@bluurryy bluurryy commented May 19, 2024

itertools version 0.13.0 added a get method that takes precedence over the EnumIter's get method. So you can no longer import itertools::Itertools in a module where you want to derive EnumIter.

To fix this we call get via fully qualified syntax.

Fixes #358.

@ijackson
Copy link
Contributor

Thanks for filing this ticket. FTR this is affecting me in derive-deftly, https://gitlab.torproject.org/Diziet/rust-derive-deftly/-/issues/84

@bluurryy bluurryy changed the title Use associated function syntax for calling get on an EnumIter, eliminating ambiguities. Use fully qualified syntax for calling get on an EnumIter, eliminating ambiguities May 22, 2024
@fenollp
Copy link

fenollp commented May 30, 2024

Hiya! What's needed to help move this forward? Thanks!

@Peternator7 Peternator7 merged commit 0c85c16 into Peternator7:master Jun 1, 2024
@Peternator7
Copy link
Owner

Peternator7 commented Jun 1, 2024

Was out for a couple weeks; thanks for fixing this! Just included this fix in 0.26.3 of strum_macros

@IgnisDa
Copy link

IgnisDa commented Jun 6, 2024

@Peternator7 Can you release v0.26.4 of strum as well? I use it with the derive feature and don't want to add strum_macros to my cargo.toml.

Thanks!

@Peternator7
Copy link
Owner

You might need to cargo update. It's pinned to 0.26 so it should prefer 0.26.4 in clean builds.

@bluurryy bluurryy deleted the enumiter-get branch May 18, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Itertools 0.13.0 and strum derive macro EnumIter break if both are used at the same time

5 participants