Take adjoint into account in xDSL MergeRotationsPass/merge_rotations_pass
#8429
+85
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v0.43.0-rc0 #8429 +/- ##
==============================================
Coverage ? 99.42%
==============================================
Files ? 584
Lines ? 61250
Branches ? 0
==============================================
Hits ? 60898
Misses ? 352
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dwierichs
added
the
review-ready 👌
1 task
mudit2812
reviewed
Oct 8, 2025
pennylane/compiler/python_compiler/transforms/quantum/merge_rotations.py
Show resolved
Hide resolved
mudit2812
approved these changes
Oct 8, 2025
pennylane/compiler/python_compiler/transforms/quantum/merge_rotations.py
Outdated
Show resolved
Hide resolved
…tations.py Co-authored-by: Mudit Pandey <[email protected]>
mehrdad2m
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Adjoints are not handled correctly, see linked issue
Description of the Change:
Handle them correctly.
Benefits:
Bug fix
Possible Drawbacks:
N/A
Related GitHub Issues:
[sc-100982]
fixes #8428