-
Couldn't load subscription status.
- Fork 706
Better error message for dynamic allocation size when capture is enabled #8381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8381 +/- ##
=======================================
Coverage 99.42% 99.42%
=======================================
Files 582 582
Lines 60902 60905 +3
=======================================
+ Hits 60551 60554 +3
Misses 351 351 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one optional suggestion.
Context:
With capture enabled, it was decided that the allocation size can only be static.
However, the current error message just falls through to whatever first error is encountered down the line. For the user this is not very actionable.
Description of the Change:
Raise a better error message.
Benefits:
Clearer suggestion for user action.
[sc-100475]