Skip to content

Conversation

@multiphaseCFD
Copy link
Member

@multiphaseCFD multiphaseCFD commented Oct 1, 2025

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    test directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the doc/releases/changelog-dev.md file, summarizing the
    change, and including a link back to the PR.

  • The PennyLane source code conforms to
    PEP8 standards.
    We check all of our code against Pylint.
    To lint modified files, simply pip install pylint, and then
    run pylint pennylane/path/to/file.py.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

[sc-100523]

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@multiphaseCFD multiphaseCFD marked this pull request as ready for review October 1, 2025 13:18
@codecov
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.41%. Comparing base (e9c839d) to head (3ffd096).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8362   +/-   ##
=======================================
  Coverage   99.41%   99.41%           
=======================================
  Files         580      580           
  Lines       60468    60468           
=======================================
  Hits        60116    60116           
  Misses        352      352           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@lillian542 lillian542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @multiphaseCFD, looks good! My only comment is, instead of including it as sort of a side-note in the tests for conversion of the H/S/RZ/Rot/CNOT gates, could we have a separate unit test that confirms that these gates are unchanged?

As is, its hard to see that that behaviour is tested without very carefully reading those tests - and if it started to fail, it wouldn't be immediately clear that the problem was the Pauli and phase gates, and not the conversion of the MBQC gates.

@multiphaseCFD
Copy link
Member Author

Thanks @multiphaseCFD, looks good! My only comment is, instead of including it as sort of a side-note in the tests for conversion of the H/S/RZ/Rot/CNOT gates, could we have a separate unit test that confirms that these gates are unchanged?

As is, its hard to see that that behaviour is tested without very carefully reading those tests - and if it started to fail, it wouldn't be immediately clear that the problem was the Pauli and phase gates, and not the conversion of the MBQC gates.

Sounds good. Let me update it.

Copy link
Contributor

@lillian542 lillian542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! 🚀

Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @multiphaseCFD
Minor suggestion, but happy to approve otherwise

@multiphaseCFD multiphaseCFD added this pull request to the merge queue Oct 2, 2025
Merged via the queue into master with commit 2fe9755 Oct 2, 2025
54 checks passed
@multiphaseCFD multiphaseCFD deleted the shuli/allow_pauli_gphase_ops_in_mbqc_transform branch October 2, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants