-
Couldn't load subscription status.
- Fork 706
[Unified Compiler] Disable error raise for Paulis/GPhase op in the convert-to-mbqc-formalism #8362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Unified Compiler] Disable error raise for Paulis/GPhase op in the convert-to-mbqc-formalism #8362
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8362 +/- ##
=======================================
Coverage 99.41% 99.41%
=======================================
Files 580 580
Lines 60468 60468
=======================================
Hits 60116 60116
Misses 352 352 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @multiphaseCFD, looks good! My only comment is, instead of including it as sort of a side-note in the tests for conversion of the H/S/RZ/Rot/CNOT gates, could we have a separate unit test that confirms that these gates are unchanged?
As is, its hard to see that that behaviour is tested without very carefully reading those tests - and if it started to fail, it wouldn't be immediately clear that the problem was the Pauli and phase gates, and not the conversion of the MBQC gates.
Sounds good. Let me update it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me! 🚀
tests/python_compiler/transforms/mbqc/test_xdsl_convert_to_mbqc_formalism.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @multiphaseCFD
Minor suggestion, but happy to approve otherwise
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
test directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
doc/releases/changelog-dev.mdfile, summarizing thechange, and including a link back to the PR.
The PennyLane source code conforms to
PEP8 standards.
We check all of our code against Pylint.
To lint modified files, simply
pip install pylint, and thenrun
pylint pennylane/path/to/file.py.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
[sc-100523]
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: