-
Notifications
You must be signed in to change notification settings - Fork 706
Port templates for Qubitization of THC Hamiltonian for resource estimation #8309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello. You may have forgotten to update the changelog!
|
…8291) **Context:** Native plxpr execution was an experimental feature that was abandoned. Too much work to get rid of, but we should at least warn people about the fact we don't care about it anymore. **Description of the Change:** **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:**
**Context:** We have been applying our fixture `seed` for a while, for reproducibility and CI stability. However, some newly added tests are free of seeding; hence they caused quite some unwanted stochastic failures. For example, the `test_horizontal_cartan_subalgebra.py`, who failed five times in Q3, and we are trying to seed it now. **Description of the Change:** **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** [sc-99735]
**Context:** So far we've been ignoring snapshots with `one-shot` and `tree-travsesal`, as each "snapshot" can correspond to many different states. **Description of the Change:** The recorded measurement/ state can now correspond to a list of multiple measurements, one for each time that snapshot is encountered. **Benefits:** **Possible Drawbacks:** This could balloon in size for many shots or many mcm's. But the user would just need to accept that. **Related GitHub Issues:** Fixes #8125 [sc-98188] --------- Co-authored-by: Mudit Pandey <[email protected]> Co-authored-by: Yushao Chen (Jerry) <[email protected]>
### Before submitting
Please complete the following checklist when submitting a PR:
- [x] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
test directory!
- [x] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running `make docs`.
- [x] Ensure that the test suite passes, by running `make test`.
- [x] Add a new entry to the `doc/releases/changelog-dev.md` file,
summarizing the
change, and including a link back to the PR.
- [x] The PennyLane source code conforms to
[PEP8 standards](https://www.python.org/dev/peps/pep-0008/).
We check all of our code against [Pylint](https://www.pylint.org/).
To lint modified files, simply `pip install pylint`, and then
run `pylint pennylane/path/to/file.py`.
When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
------------------------------------------------------------------------------------------------------------
**Context:**
In some scenarios like QROM it is necessary that Select decompose using
one auxiliary qubit to control over the target operators. This new
Select decomposition achieves that.
<img width="469" height="147" alt="Screenshot 2025-09-15 at 4 04 51 PM"
src="https://github.com/user-attachments/assets/20d40261-5fbf-4016-bb3e-7e26423e3e67"
/>
---------
Co-authored-by: JerryChen97 <[email protected]>
Co-authored-by: David Wierichs <[email protected]>
Co-authored-by: Diego <[email protected]>
**Context:** Qnodes are supported by estimate(). **Description of the Change:** **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** --------- Co-authored-by: ANT0N <[email protected]>
Co-authored-by: ANT0N <[email protected]>
Co-authored-by: ANT0N <[email protected]>
Co-authored-by: ANT0N <[email protected]>
Co-authored-by: ANT0N <[email protected]>
Co-authored-by: ANT0N <[email protected]>
Co-authored-by: ANT0N <[email protected]>
Co-authored-by: ANT0N <[email protected]>
Co-authored-by: ANT0N <[email protected]>
…dd_qubitization_templates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me! 👍🏼
Thanks for propagating all of my suggestions from earlier PRs up to this one!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ddhawan11!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few docs comments otherwise its good to go
Context:
This PR moves templates required for resource estimation of qubitization of THC Hamiltonian.
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: