Skip to content

Port subroutine resource templates to estimator #8300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 635 commits into from
Sep 29, 2025
Merged

Port subroutine resource templates to estimator #8300

merged 635 commits into from
Sep 29, 2025

Conversation

@soranjh
Copy link
Contributor

@soranjh soranjh commented Sep 18, 2025

Context:
Add subroutine resource templates to estimator.

Description of the Change:
The following resource templates are added.

OutOfPlaceSquare
PhaseGradient
OutMultiplier
SemiAdder
QFT
AQFT
BasisRotation
Select
QROM
SelectPauliRot
QubitUnitary
ControlledSequence
QPE
IterativeQPE

Benefits:

Possible Drawbacks:

Related GitHub Issues:

soranjh and others added 30 commits September 17, 2025 17:23
@soranjh
remove tests
a6fef0c
@soranjh
add symbolic
f2d5ce7
@soranjh
fix conflict
d7bfeeb
@soranjh
update init
b8fd88e
@ddhawan11
Updated adjoint class
4fe179e
@ddhawan11
Merge branch 'master' into add-single-paramteric-ops
8da4b95
@soranjh
update arg name
3f936d0
@ddhawan11
Updated typechecks for nonparametric
050452a
@ddhawan11
Merge remote-tracking branch 'origin/add-single-paramteric-ops' into …
a1a364a 
…add-controlled-ops
@ddhawan11
Merge branch 'add-controlled-ops' into add-control-adjoint-symbolic
f08c485
@ddhawan11
Update pennylane/estimator/ops/qubit/parametric_ops_single_qubit.py
b18e188
@soranjh
update arg name
6a304e4
@ddhawan11
Fixed tesst
9472959
@ddhawan11 @andrijapau
Update pennylane/estimator/ops/op_math/controlled_ops.py
0cb6524 
Co-authored-by: Andrija Paurevic <[email protected]>
@ddhawan11 @andrijapau
Update pennylane/estimator/ops/op_math/controlled_ops.py
187bfe5 
Co-authored-by: Andrija Paurevic <[email protected]>
@ddhawan11
Added typechecks
5dfc807
@ddhawan11
Increased test coverage
a973e74
@ddhawan11
Update tests/estimator/test_estimator_resOp.py
f42426d
@ddhawan11
Fixed tests and signature
4423f43
@ddhawan11
Fixed documentation
7b23eb0
@ddhawan11
Fix docs
87be3ed
@ddhawan11
Fix docs
d7d99f2
@ddhawan11
minor doc fix
ba954a3
@ddhawan11
minor doc fix
64a6061
@ddhawan11
fixed docs build
18d9afc
@ddhawan11
fixed rendering
a6a5cc2
@ddhawan11
Merge branch 'add-control-adjoint-symbolic' into add-multi-qubit-para…
ec5c2eb 
…metric
@ddhawan11
Fixed examples
fa248c9
@ddhawan11
Update pennylane/estimator/__init__.py
57dd102
@ddhawan11 @soranjh
Update pennylane/estimator/ops/op_math/controlled_ops.py
165eef0 
Co-authored-by: Soran Jahangiri <[email protected]>
andrijapau
andrijapau reviewed Sep 25, 2025
View reviewed changes
Copy link
Contributor

@andrijapau andrijapau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some questions, but overall I'm ready to approve!

andrijapau
andrijapau approved these changes Sep 25, 2025
View reviewed changes
Copy link
Contributor

@andrijapau andrijapau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. Again not feasible for me to check the validity of all the decompositions but I entrust that they are valid. 😄

AntonNI8
AntonNI8 reviewed Sep 25, 2025
View reviewed changes
ddhawan11
ddhawan11 reviewed Sep 25, 2025
View reviewed changes
ddhawan11
ddhawan11 reviewed Sep 25, 2025
View reviewed changes
AntonNI8
AntonNI8 approved these changes Sep 26, 2025
View reviewed changes
Copy link
Contributor

@AntonNI8 AntonNI8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples will need to be updated in a follow up PR, but this looks good. Thank you @soranjh 💪🏻

@soranjh soranjh requested a review from ddhawan11 September 26, 2025 13:09
@soranjh soranjh enabled auto-merge September 29, 2025 11:06
@soranjh soranjh added this pull request to the merge queue Sep 29, 2025
Merged via the queue into master with commit e73fbe1 Sep 29, 2025
52 checks passed
@soranjh soranjh deleted the add-subroutines-to-estimator branch September 29, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AntonNI8 AntonNI8 AntonNI8 approved these changes

@andrijapau andrijapau andrijapau approved these changes

@albi3ro albi3ro Awaiting requested review from albi3ro

@ddhawan11 ddhawan11 Awaiting requested review from ddhawan11

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@soranjh @albi3ro @AntonNI8 @ddhawan11 @andrijapau @austingmhuang