Skip to content

Conversation

@soranjh
Copy link
Contributor

@soranjh soranjh commented Sep 12, 2025

Context:
A generator in effective_hamiltonian is updated to fix an issue raised by concurrency for parallel runs with mpi4py_pool.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link
Contributor

@willjmax willjmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests pass now 🚀

@soranjh soranjh marked this pull request as ready for review September 25, 2025 18:40
@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.40%. Comparing base (f818dc2) to head (2066186).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8257      +/-   ##
==========================================
- Coverage   99.40%   99.40%   -0.01%     
==========================================
  Files         575      575              
  Lines       59347    59347              
==========================================
- Hits        58995    58994       -1     
- Misses        352      353       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@soranjh soranjh enabled auto-merge September 25, 2025 19:23
@soranjh soranjh added this pull request to the merge queue Sep 25, 2025
Merged via the queue into master with commit 0b6dd75 Sep 25, 2025
52 checks passed
@soranjh soranjh deleted the fix_labs_effective_ham branch September 25, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants