- 
                Notifications
    You must be signed in to change notification settings 
- Fork 706
RZ Phase gradient method transform #8213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Hello. You may have forgotten to update the changelog! 
 | 
| Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@            Coverage Diff             @@
##           master    #8213      +/-   ##
==========================================
- Coverage   99.40%   99.39%   -0.01%     
==========================================
  Files         562      563       +1     
  Lines       58197    58232      +35     
==========================================
+ Hits        57848    57882      +34     
- Misses        349      350       +1     ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already looks like a very nice version to me!
Main points:
- Naming/number of registers for aux/work
- Use of ChangeOpBasis
And then more tests for multiple RZ gates, different precisions and the like, once you're going for the finish line :)
| [sc-99057] | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Let me know if you want to have a chat to go through the comments together more quickly 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks @Qottmann
Just some docs polishing/render debugging before approving :)
Co-authored-by: David Wierichs <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Nice to see this in PL 🚀
| @Qottmann, don't forget the changelog | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Really nicely documented now. Approved after final comments are addressed 🥳
requested by Diego
Usage would look something like this: