-
Couldn't load subscription status.
- Fork 706
SampleMP include a dtype optional parameter
#8189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello. You may have forgotten to update the changelog!
|
…o precision_optional_parameter
precision optional parameterSampleMP include a precision optional parameter
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8189 +/- ##
==========================================
- Coverage 99.39% 99.39% -0.01%
==========================================
Files 550 550
Lines 57026 57032 +6
==========================================
+ Hits 56683 56688 +5
- Misses 343 344 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…o precision_optional_parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we actually call this dtype instead of precision?
SampleMP include a precision optional parameterSampleMP include a dtype optional parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think having dtype from now on is a great choice, aligned with all the other common libraries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Context: This PR adds the
dtypeoptional parameter for theSampleMPmeasurement process.Description of the Change: As above.
Benefits: More flexibility and very small (mostly symbolic) speed-up improvement
Possible Drawbacks: None that I can think of.
Related GitHub Issues: None.
[sc-98358]