Skip to content

Conversation

@PietropaoloFrisoni
Copy link
Contributor

@PietropaoloFrisoni PietropaoloFrisoni commented Sep 3, 2025

Context: This PR adds the dtype optional parameter for the SampleMP measurement process.

Description of the Change: As above.

Benefits: More flexibility and very small (mostly symbolic) speed-up improvement

Possible Drawbacks: None that I can think of.

Related GitHub Issues: None.

[sc-98358]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@PietropaoloFrisoni PietropaoloFrisoni changed the title Measurements include a precision optional parameter SampleMP include a precision optional parameter Sep 3, 2025
@PietropaoloFrisoni PietropaoloFrisoni marked this pull request as ready for review September 4, 2025 14:35
@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.39%. Comparing base (419615c) to head (d14f2f1).
⚠️ Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8189      +/-   ##
==========================================
- Coverage   99.39%   99.39%   -0.01%     
==========================================
  Files         550      550              
  Lines       57026    57032       +6     
==========================================
+ Hits        56683    56688       +5     
- Misses        343      344       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we actually call this dtype instead of precision?

@PietropaoloFrisoni PietropaoloFrisoni changed the title SampleMP include a precision optional parameter SampleMP include a dtype optional parameter Sep 5, 2025
Copy link
Contributor

@JerryChen97 JerryChen97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think having dtype from now on is a great choice, aligned with all the other common libraries

Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@PietropaoloFrisoni PietropaoloFrisoni added this pull request to the merge queue Sep 12, 2025
Merged via the queue into master with commit 73a4e78 Sep 12, 2025
52 checks passed
@PietropaoloFrisoni PietropaoloFrisoni deleted the precision_optional_parameter branch September 12, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants