Skip to content

Conversation

@astralcai
Copy link
Contributor

Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:
[sc-98523]

@astralcai astralcai requested a review from albi3ro September 2, 2025 15:23
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Sep 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.69%. Comparing base (b51f590) to head (aa52b3a).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8179      +/-   ##
==========================================
- Coverage   99.69%   99.69%   -0.01%     
==========================================
  Files         548      548              
  Lines       56806    56842      +36     
==========================================
+ Hits        56633    56668      +35     
- Misses        173      174       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we should just define the def_impl primitives for allocate_prim and deallocate_prim at this time too. Might cause some issues, but probably fewer issues than the NotImplementedError.

@astralcai
Copy link
Contributor Author

Wondering if we should just define the def_impl primitives for allocate_prim and deallocate_prim at this time too. Might cause some issues, but probably fewer issues than the NotImplementedError.

We could, but I don't think it's needed anywhere else other than plxpr_to_tape

@astralcai astralcai requested a review from albi3ro September 3, 2025 23:59
Copy link
Contributor

@PietropaoloFrisoni PietropaoloFrisoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Just 2 non blocking comments about documentation (one is about a class that was moved in this PR)

@astralcai astralcai enabled auto-merge September 4, 2025 19:12
@astralcai astralcai added this pull request to the merge queue Sep 4, 2025
Merged via the queue into master with commit b26cc42 Sep 4, 2025
52 checks passed
@astralcai astralcai deleted the interpret-alloc branch September 4, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants