-
Couldn't load subscription status.
- Fork 706
plxpr_to_tape supports dynamic wire allocation #8179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8179 +/- ##
==========================================
- Coverage 99.69% 99.69% -0.01%
==========================================
Files 548 548
Lines 56806 56842 +36
==========================================
+ Hits 56633 56668 +35
- Misses 173 174 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if we should just define the def_impl primitives for allocate_prim and deallocate_prim at this time too. Might cause some issues, but probably fewer issues than the NotImplementedError.
Co-authored-by: Christina Lee <[email protected]>
We could, but I don't think it's needed anywhere else other than |
…o interpret-alloc
…o interpret-alloc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Just 2 non blocking comments about documentation (one is about a class that was moved in this PR)
Co-authored-by: Pietropaolo Frisoni <[email protected]>
Context:
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-98523]