Skip to content

Conversation

@Qottmann
Copy link
Contributor

@Qottmann Qottmann commented Sep 1, 2025

These IRs are mature enough to be moved to mainline PL.
Can also consider moving rowcol to mainline PL (optional - happy to hear feedback)

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2025

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@Qottmann Qottmann requested a review from a team as a code owner September 1, 2025 09:45
@Qottmann
Copy link
Contributor Author

Qottmann commented Sep 1, 2025

I didnt request the review intentionally (not sure if this is done automatically for new PRs?) - but this is still very much a WIP!

@andrijapau andrijapau removed the request for review from a team September 2, 2025 13:30
@andrijapau
Copy link
Contributor

I didnt request the review intentionally (not sure if this is done automatically for new PRs?) - but this is still very much a WIP!

Untagged us. 🙂

@JerryChen97
Copy link
Contributor

After merging master into this branch, we still see the same error. So I don't think it's caused by the xdsl tests

@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.40%. Comparing base (8150a68) to head (fdff24f).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8171      +/-   ##
==========================================
- Coverage   99.40%   99.40%   -0.01%     
==========================================
  Files         571      575       +4     
  Lines       59198    59347     +149     
==========================================
+ Hits        58846    58994     +148     
- Misses        352      353       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Qottmann Qottmann enabled auto-merge September 22, 2025 09:56
@Qottmann
Copy link
Contributor Author

Codecov is complaining that the galois import is not tested, but it should be covered by the TestRowCol tests in test_rowcol.py that are marked as external (which includes having the galois dependency 🤔 )

image

Is this a codecov bug or am I missing something?

@Qottmann Qottmann added this pull request to the merge queue Sep 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 23, 2025
@Qottmann Qottmann enabled auto-merge September 25, 2025 07:25
@Qottmann Qottmann added this pull request to the merge queue Sep 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 25, 2025
@Qottmann Qottmann added this pull request to the merge queue Sep 25, 2025
Merged via the queue into master with commit f818dc2 Sep 25, 2025
52 checks passed
@Qottmann Qottmann deleted the IRs branch September 25, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants