-
Couldn't load subscription status.
- Fork 706
Make MidMeasureMP an operator #8166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello. You may have forgotten to update the changelog!
|
|
Now that |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8166 +/- ##
==========================================
- Coverage 99.69% 99.69% -0.01%
==========================================
Files 548 548
Lines 56784 56830 +46
==========================================
+ Hits 56610 56654 +44
- Misses 174 176 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in stand I took a look just at the changes to the FTQC module. No concerns on my end!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR will have consequences (hopefully improvements) for the visualization work with the unified compiler 🤞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 😄
Context:
We've long had issues where
MidMeasureMPtechnically inherits fromMeasurementProcess, but it always acts like anOperator. This leads us to problems where methods are missing and our pipeline can't handle it.Description of the Change:
Makes
MidMeasureMPinherit fromOperatorand makes associated style switches.Benefits:
Possible Drawbacks:
Related GitHub Issues:
Related Shortcut Stories:
[sc-98587] [sc-51791]