Skip to content

Conversation

@albi3ro
Copy link
Contributor

@albi3ro albi3ro commented Aug 29, 2025

Context:

We've long had issues where MidMeasureMP technically inherits from MeasurementProcess, but it always acts like an Operator. This leads us to problems where methods are missing and our pipeline can't handle it.

Description of the Change:

Makes MidMeasureMP inherit from Operator and makes associated style switches.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

Related Shortcut Stories:
[sc-98587] [sc-51791]

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@astralcai
Copy link
Contributor

Now that MidMeasureMP is not a MeasurementProcess anymore, we might want to stop calling it an "MP", potentially we can rename it to just MidMeasure?

@albi3ro albi3ro changed the title [TEST] make MidMeasureMP an operator Make MidMeasureMP an operator Sep 5, 2025
@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.69%. Comparing base (d954267) to head (fab6bf8).
⚠️ Report is 41 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8166      +/-   ##
==========================================
- Coverage   99.69%   99.69%   -0.01%     
==========================================
  Files         548      548              
  Lines       56784    56830      +46     
==========================================
+ Hits        56610    56654      +44     
- Misses        174      176       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@lillian542 lillian542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in stand I took a look just at the changes to the FTQC module. No concerns on my end!

Copy link
Contributor

@PietropaoloFrisoni PietropaoloFrisoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR will have consequences (hopefully improvements) for the visualization work with the unified compiler 🤞

Copy link
Contributor

@andrijapau andrijapau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😄

@albi3ro albi3ro added this pull request to the merge queue Sep 10, 2025
Merged via the queue into master with commit e8a5bab Sep 10, 2025
52 checks passed
@albi3ro albi3ro deleted the mid-measure-as-operator branch September 10, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants