-
Couldn't load subscription status.
- Fork 706
Add warning about precision in interfaces documentation #8124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8124 +/- ##
==========================================
- Coverage 99.40% 99.40% -0.01%
==========================================
Files 550 550
Lines 56969 56969
==========================================
- Hits 56631 56630 -1
- Misses 338 339 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this warning! 🙌
The line was a bit long so I just suggested making it into two lines.
Remember to add an entry to the changelog in the "documentation" section.
Co-authored-by: Catalina Albornoz <[email protected]>
Added - thanks @CatalinaAlbornoz! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Isaac De Vlugt <[email protected]>
Co-authored-by: Isaac De Vlugt <[email protected]>
Co-authored-by: Isaac De Vlugt <[email protected]>
Context:
A user query on our forum (Thread #8885) revealed that PennyLane silently promotes all float32 inputs to float64 during computation.
Description of the Change:
This change adds a warning to the Interfaces documentation regarding the behaviour (everything is promoted to 64-bit outputs).
Benefits:
Possible Drawbacks:
Related GitHub Issues: