-
Couldn't load subscription status.
- Fork 706
[FTQC] Add diagonalize_mcms support to the convert_to_mbqc_formalism transform
#8105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8105 +/- ##
=======================================
Coverage 99.69% 99.69%
=======================================
Files 548 548
Lines 56845 56928 +83
=======================================
+ Hits 56672 56755 +83
Misses 173 173 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey @lillian542 , I just pushed a very commit based on our conversion about the diagonalize_mcms fix. Let me know if you're ok with the UI. I might remove the diagonalize_mcms from the parametric_midmeasure module. |
convert_to_mbqc_formalism transform
convert_to_mbqc_formalism transformconvert_to_mbqc_formalism transform
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @multiphaseCFD!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I only had a few editorial comments. Thanks @multiphaseCFD! 🚀
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
test directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
doc/releases/changelog-dev.mdfile, summarizing thechange, and including a link back to the PR.
The PennyLane source code conforms to
PEP8 standards.
We check all of our code against Pylint.
To lint modified files, simply
pip install pylint, and thenrun
pylint pennylane/path/to/file.py.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
[sc-98373]
This PR is a workaround for fixing the issue of
MeasurementValuetransform in thediagonalize_mcmstransform. Note this is temporal workaround for the FTQC workflow validation purpose.Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: