Skip to content

Conversation

@multiphaseCFD
Copy link
Member

@multiphaseCFD multiphaseCFD commented Aug 19, 2025

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    test directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the doc/releases/changelog-dev.md file, summarizing the
    change, and including a link back to the PR.

  • The PennyLane source code conforms to
    PEP8 standards.
    We check all of our code against Pylint.
    To lint modified files, simply pip install pylint, and then
    run pylint pennylane/path/to/file.py.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

[sc-98373]

This PR is a workaround for fixing the issue of MeasurementValue transform in the diagonalize_mcms transform. Note this is temporal workaround for the FTQC workflow validation purpose.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Aug 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.69%. Comparing base (0078f06) to head (9dc7cde).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8105   +/-   ##
=======================================
  Coverage   99.69%   99.69%           
=======================================
  Files         548      548           
  Lines       56845    56928   +83     
=======================================
+ Hits        56672    56755   +83     
  Misses        173      173           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@multiphaseCFD
Copy link
Member Author

Hey @lillian542 , I just pushed a very commit based on our conversion about the diagonalize_mcms fix. Let me know if you're ok with the UI. I might remove the diagonalize_mcms from the parametric_midmeasure module.

@multiphaseCFD multiphaseCFD changed the title [WIP] Fix for diagonalize_mcms Add diagonalize_mcms support to the convert_to_mbqc_formalism transform Sep 4, 2025
@multiphaseCFD multiphaseCFD changed the title Add diagonalize_mcms support to the convert_to_mbqc_formalism transform [FTQC] Add diagonalize_mcms support to the convert_to_mbqc_formalism transform Sep 4, 2025
@multiphaseCFD multiphaseCFD requested a review from a team September 5, 2025 15:54
Copy link
Contributor

@lillian542 lillian542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @multiphaseCFD!

Copy link
Contributor

@joeycarter joeycarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I only had a few editorial comments. Thanks @multiphaseCFD! 🚀

@multiphaseCFD multiphaseCFD added this pull request to the merge queue Sep 5, 2025
Merged via the queue into master with commit 2498b24 Sep 5, 2025
52 checks passed
@multiphaseCFD multiphaseCFD deleted the shuli/fix_mv_diagonalize_mcms branch September 5, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants