Skip to content

Conversation

@andrijapau
Copy link
Contributor

@andrijapau andrijapau commented Aug 19, 2025

Context

Both qjit and qnode currently have an autograph kwarg (with default values False and True respectively).

The solution is that we will use the disable context manager and run_autograph for now, and remove the autograph kwarg from the QNode in favour of only the qjit decorator and the context managers.

Description of the Change

Basically just reverts the changes that were made when this kwarg was added (#6837).

Benefits

Aligned with our approach to unify PL and Catalyst.

Possible Drawbacks

None identified.

[sc-92903]

@github-actions

This comment was marked as resolved.

@andrijapau andrijapau added the WIP 🚧 Work-in-progress label Aug 19, 2025
@andrijapau andrijapau changed the title feat: autograph: remove autograph kwarg from QNode constructor chore: autograph: remove autograph kwarg from QNode constructor Aug 21, 2025
@codecov
Copy link

codecov bot commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.69%. Comparing base (f040c58) to head (0378b65).
⚠️ Report is 21 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8104      +/-   ##
==========================================
- Coverage   99.69%   99.69%   -0.01%     
==========================================
  Files         547      547              
  Lines       56496    56494       -2     
==========================================
- Hits        56321    56319       -2     
  Misses        175      175              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrijapau andrijapau removed the WIP 🚧 Work-in-progress label Aug 22, 2025
@andrijapau andrijapau requested a review from albi3ro August 26, 2025 16:03
@andrijapau andrijapau requested a review from astralcai August 26, 2025 16:04
@andrijapau andrijapau added this pull request to the merge queue Aug 28, 2025
Merged via the queue into master with commit 71763f7 Aug 28, 2025
52 checks passed
@andrijapau andrijapau deleted the autograph/rmv-autograph-kwarg branch August 28, 2025 18:37
andrijapau added a commit to PennyLaneAI/catalyst that referenced this pull request Aug 29, 2025
**Context:**

We are removing the `autograph` kwarg at the QNode level in favour of
`disable_autograph` / `run_autograph` + `qjit` (see PL PR
PennyLaneAI/pennylane#8104).

~~⚠️ Tests are failing but that is expected and should be fixed once the
PL PR merges as autograph will be off by default.~~

[sc-92903]

---------

Co-authored-by: paul0403 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants