Skip to content

Conversation

@soranjh
Copy link
Contributor

@soranjh soranjh commented Aug 13, 2025

Context:
Implements concurrency in effective_hamiltonian to support running parallel jobs.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@soranjh soranjh marked this pull request as ready for review August 13, 2025 21:41
@codecov
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.69%. Comparing base (4d684c6) to head (d4251b5).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8081   +/-   ##
=======================================
  Coverage   99.69%   99.69%           
=======================================
  Files         548      548           
  Lines       56845    56845           
=======================================
  Hits        56672    56672           
  Misses        173      173           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@soranjh soranjh changed the title [WIP] add concurrency support for effective_hamiltonian in labs Add concurrency support for effective_hamiltonian in labs Aug 28, 2025
@soranjh soranjh requested a review from willjmax September 2, 2025 19:30
Copy link
Contributor

@willjmax willjmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two minor changes needed.

Copy link
Contributor

@obliviateandsurrender obliviateandsurrender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add a changelog entry. 🚂

Copy link
Contributor

@willjmax willjmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

@soranjh soranjh added this pull request to the merge queue Sep 5, 2025
@soranjh soranjh removed this pull request from the merge queue due to a manual request Sep 5, 2025
@soranjh soranjh added this pull request to the merge queue Sep 5, 2025
Merged via the queue into master with commit 0078f06 Sep 5, 2025
52 checks passed
@soranjh soranjh deleted the concurrency_effective_hamiltonian branch September 5, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants