Skip to content

Conversation

@comp-phys-marc
Copy link
Contributor

@comp-phys-marc comp-phys-marc commented Aug 13, 2025


Context: We would like to add qfunc decompositions for templates including arbitrary state prep, cosine window, amplitude amplification, permute, AQFT, FlipSign, FABLE.

Description of the Change: Adds decomp(s) for these template(s).

Benefits: The template(s) are now compatible with the new system.

Possible Drawbacks:

Related ShortCut Stories: [sc-97636]

@PennyLaneAI PennyLaneAI deleted a comment from github-actions bot Aug 13, 2025
@comp-phys-marc comp-phys-marc changed the title Arbitrary state prep qfunc decomp Arbitrary state prep, cosine window, amplitude amplification, permute, AQFT, FlipSign, FABLE decomps Aug 13, 2025
@comp-phys-marc comp-phys-marc marked this pull request as ready for review August 19, 2025 13:31
@codecov
Copy link

codecov bot commented Aug 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.68%. Comparing base (344bd7c) to head (e7fb8c7).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8075      +/-   ##
==========================================
- Coverage   99.68%   99.68%   -0.01%     
==========================================
  Files         546      546              
  Lines       56187    56449     +262     
==========================================
+ Hits        56012    56273     +261     
- Misses        175      176       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@comp-phys-marc comp-phys-marc changed the title Arbitrary state prep, cosine window, amplitude amplification, permute, AQFT, FlipSign, FABLE decomps Arbitrary state prep, cosine window, amplitude amplification, permute, AQFT, FlipSign, FABLE qfunc decomps Aug 19, 2025
@astralcai astralcai self-requested a review August 19, 2025 21:18
comp-phys-marc and others added 2 commits August 20, 2025 11:04
	- Use dict instead of counter
Copy link
Contributor

@PietropaoloFrisoni PietropaoloFrisoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great. Thanks @comp-phys-marc !

Copy link
Contributor

@astralcai astralcai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove most unnecessary use of Counter? Otherwise happy to approve.

@comp-phys-marc comp-phys-marc added this pull request to the merge queue Aug 25, 2025
Merged via the queue into master with commit 2b01b67 Aug 25, 2025
52 checks passed
@comp-phys-marc comp-phys-marc deleted the feature/more-p2-qfunc-decomps branch August 25, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants