Add a no_analytic transform #8037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Andrija Paurevic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
We have
no_samplingas a transform to ensure compatibility with certain execution pathways that only work with analytic execution, but we don't have ano_analytictransform, which is relevant for hardware devices.To provide this functionality to date, we've been validating that
device.shots != Nonein device__init__s, instead of validating the tape shots in the transform program. This is no longer the direction we want to go, as we are deprecatingdevice.shots, and also isn't the ideal place for validation because calls to the QNode can overridedevice.shots.Description of the Change:
We add a
no_analytictransformBenefits:
It's better practice, and it supports the deprecation of
device.shotsin plugins.[sc-97221]