Skip to content

Conversation

@astralcai
Copy link
Contributor

Context:

Description of the Change:
Splitting the solution part of a DecompositionGraph to a separate DecompGraphSolution class, returned by the solve method.

Benefits:
Cleaner code

Possible Drawbacks:

Related GitHub Issues:
[sc-97093]

@astralcai astralcai requested review from albi3ro and maliasadi August 6, 2025 14:49
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.68%. Comparing base (56c74cb) to head (3320996).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8031      +/-   ##
==========================================
- Coverage   99.68%   99.68%   -0.01%     
==========================================
  Files         543      543              
  Lines       56204    56220      +16     
==========================================
+ Hits        56029    56044      +15     
- Misses        175      176       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @astralcai! Just a few suggestions before approving the PR

@astralcai astralcai requested a review from maliasadi August 8, 2025 13:12
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙌

Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog?

But thanks for making this split! Great how well it worked right out of the box 🚀

@astralcai astralcai enabled auto-merge August 11, 2025 15:42
@astralcai astralcai added this pull request to the merge queue Aug 11, 2025
Merged via the queue into master with commit 8630f5b Aug 11, 2025
55 checks passed
@astralcai astralcai deleted the split-decomp-graph branch August 11, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants