-
Couldn't load subscription status.
- Fork 706
Refactor DecompositionGraph to two classes #8031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8031 +/- ##
==========================================
- Coverage 99.68% 99.68% -0.01%
==========================================
Files 543 543
Lines 56204 56220 +16
==========================================
+ Hits 56029 56044 +15
- Misses 175 176 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @astralcai! Just a few suggestions before approving the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog?
But thanks for making this split! Great how well it worked right out of the box 🚀
Context:
Description of the Change:
Splitting the solution part of a
DecompositionGraphto a separateDecompGraphSolutionclass, returned by thesolvemethod.Benefits:
Cleaner code
Possible Drawbacks:
Related GitHub Issues:
[sc-97093]