feat: autograph: add support for pythonic index assignment w/ jax.numpy arrays
#8027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8027 +/- ##
=======================================
Coverage 99.68% 99.68%
=======================================
Files 545 545
Lines 56137 56143 +6
=======================================
+ Hits 55961 55967 +6
Misses 176 176 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrijapau
commented
Aug 11, 2025
andrijapau
changed the title
autograph modulejax.numpy arrays
andrijapau
changed the title
jax.numpy arraysjax.numpy arrays
andrijapau
commented
Aug 11, 2025
andrijapau
commented
Aug 12, 2025
andrijapau
commented
Aug 18, 2025
andrijapau
changed the title
jax.numpy arraysjax.numpy arrays
comp-phys-marc
approved these changes
Aug 20, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 25, 2025
… `-=`, ...) (#8076) ## Context This is an in-direct follow-up PR to #8027. Now that we have index assignment. We wish to add in-place array updates using pythonic notation. ## Description of the Change This PR directly mirrors the changes made to Catalyst [here](PennyLaneAI/catalyst#1143). Basically, the gist is that we added the `SingleIndexArrayOperatorUpdateTransformer` class that is able to use autograph to properly convert any detected array update in our AST. ## Benefits This allows us to do things like, ```python import pennylane as qml qml.capture.enable() from pennylane.capture import make_plxpr import jax import jax.numpy as jnp def f(): # setup my_list = [0, 1] my_list = jnp.empty(2, dtype=int) for i in range(2): my_list[i] = i # increment second element by ten my_list[1] += 10 return my_list >>> plxpr = make_plxpr(f)() >>> jax.core.eval_jaxpr(plxpr.jaxpr, []) [Array([0, 11], dtype=int32)] ``` ## Possible Drawbacks None identified. [sc-76134] --------- Co-authored-by: Pietropaolo Frisoni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Current autograph implementation in PL only supports converting functions that use the
jax.numpysyntaxarr = arr.at[i].set(x)to update array indices.We would like to be able to do
arr[i] = xinstead of raising an error.Description of the Change
Updates
ag_primitivesto allow the transformer to update the indices accordingly.Benefits
We now have functional code,
Possible Drawbacks
None identified.
[sc-76133]