Skip to content

Conversation

@astralcai
Copy link
Contributor

Context:

Description of the Change:
Update the default implementation of Device.setup_execution_config to use the "device" MCM method if "device" is available, regardless of finite shots or not.

Benefits:
Aligns with the default strategy discussed.

Possible Drawbacks:
The only devices affected by this are one that defines a TOML file with "device" included in its mcm methods, and does not override preprocess, which is none of the devices.

Related GitHub Issues:
[sc-95418]

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.68%. Comparing base (cc5600c) to head (d9ea6c8).
⚠️ Report is 424 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7968   +/-   ##
=======================================
  Coverage   99.68%   99.68%           
=======================================
  Files         542      542           
  Lines       55650    55650           
=======================================
  Hits        55476    55476           
  Misses        174      174           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@andrijapau andrijapau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@astralcai astralcai added this pull request to the merge queue Jul 28, 2025
Merged via the queue into master with commit 9491e9c Jul 28, 2025
54 checks passed
@astralcai astralcai deleted the default-mcm branch July 28, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants