QROM subroutine func decomp #7941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Astral Cai <[email protected]>
…ps' into feature/q1_subroutine_func_decomps
comp-phys-marc
changed the title
comp-phys-marc
changed the base branch from
feature/q1_subroutine_func_decomps
to
master
comp-phys-marc
changed the base branch from
master
to
feature/q1_subroutine_func_decomps
Co-authored-by: Astral Cai <[email protected]>
Co-authored-by: Astral Cai <[email protected]>
…ps' into feature/q1_subroutine_func_decomps
Co-authored-by: Astral Cai <[email protected]>
mudit2812
reviewed
Jul 30, 2025
mudit2812
reviewed
Jul 30, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7941 +/- ##
=======================================
Coverage 99.68% 99.68%
=======================================
Files 543 543
Lines 55966 56063 +97
=======================================
+ Hits 55791 55888 +97
Misses 175 175 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mudit2812
approved these changes
Jul 31, 2025
isaacdevlugt
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: We would like to make the QROM subroutine template compatible with the new decompositions system.
Description of the Change: Adds a qfunc decomposition for QROM.
Benefits: The QROM template is now compatible with the new system.
Possible Drawbacks:
Related Shortcut Stories: [sc-96017]