fixing 1 qubit-size SemiAdder #7940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7940 +/- ##
==========================================
- Coverage 99.68% 99.68% -0.01%
==========================================
Files 542 542
Lines 55616 55622 +6
==========================================
+ Hits 55443 55448 +5
- Misses 173 174 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JerryChen97
reviewed
Jul 24, 2025
|
Also do we have a story for this PR? |
Co-authored-by: Yushao Chen (Jerry) <[email protected]>
|
[sc-96288] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
the SemiAdder was not working in the edge case of x + y defined with a single qubit. This PR covers this situation
Description of the Change:
In this scenario, the semiAdder is a CNOT.
Note that in this case work_wires are not needed. So I had to change the logic that was assuming we always have work wires
Benefits:
Possible Drawbacks:
Related GitHub Issues: