Skip to content

Conversation

@andrijapau
Copy link
Contributor

@andrijapau andrijapau commented Jul 21, 2025

As the name suggests 😄 .

Side effects to note,

  • pylint was bumped to latest (3.3.7) in order to be compatible with 3.11. Since the minimum supported version (3.0.0) had false negatives / positives which were subsequently fixed in later versions it makes sense to skip to latest. Some errors needed to get suppressed at the pylintrc level as there were too many to tackle at once (or require discussion like too-many-positional-arguments.
  • Upgraded black and isort to latest.

[sc-95555]
[sc-91391]

@andrijapau andrijapau changed the title chore: drop Python 3.10 support chore: drop support for Python 3.10 and add support for Python 3.13 Jul 21, 2025
@andrijapau andrijapau marked this pull request as draft July 23, 2025 17:23
@andrijapau andrijapau marked this pull request as ready for review July 23, 2025 17:28
@codecov
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.68%. Comparing base (6714385) to head (00e7f7a).
⚠️ Report is 420 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7935      +/-   ##
==========================================
- Coverage   99.69%   99.68%   -0.01%     
==========================================
  Files         543      543              
  Lines       55964    55964              
==========================================
- Hits        55791    55790       -1     
- Misses        173      174       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

add stories for pylint tracking
@rashidnhm rashidnhm added the urgent Mark a pull request as high priority label Jul 31, 2025
@andrijapau andrijapau added gpu ci:run-full-test-suite Run the full test-suite on the pull request labels Jul 31, 2025
@rashidnhm
Copy link
Contributor

Should we update the required tests now?

@andrijapau
Copy link
Contributor Author

Should we update the required tests now?

Yes, or we can do it after it merges?

Copy link
Contributor

@lillian542 lillian542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rashidnhm
Copy link
Contributor

Yes, or we can do it after it merges?

We can do it after, but then branch would require force merge by admin

@multiphaseCFD
Copy link
Member

Just wondering if we could get this PR merged? It's a blocker for the FTQC. Thanks @andrijapau

@andrijapau
Copy link
Contributor Author

andrijapau commented Aug 1, 2025

Just wondering if we could get this PR merged? It's a blocker for the FTQC. Thanks @andrijapau

Yes, just waiting on #7996 (review) to merge in order to free up CI to merge this PR.

@andrijapau andrijapau enabled auto-merge August 1, 2025 17:18
@andrijapau andrijapau added this pull request to the merge queue Aug 1, 2025
Merged via the queue into master with commit f236db9 Aug 1, 2025
133 of 139 checks passed
@andrijapau andrijapau deleted the drop-python-310-support branch August 1, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:run-full-test-suite Run the full test-suite on the pull request gpu urgent Mark a pull request as high priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants