Add support for QASM 3.0 qubit registers #7767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Astral Cai <[email protected]>
- getattr doesn't handle a KeyError
- Remove extra specificity from scope names - fix docstring - sub context wires now populated with outer context wires
mudit2812
reviewed
Jul 18, 2025
There was a problem hiding this comment.
Thanks @comp-phys-marc! I've left my first round of comments. Also asked some questions - I think I would benefit a lot from understanding the implementation a bit more before approving the PR.
Co-authored-by: Mudit Pandey <[email protected]>
- parentheses and comments for clarity
…ature/qubit-registers
Co-authored-by: Mudit Pandey <[email protected]>
Co-authored-by: Mudit Pandey <[email protected]>
…ature/qubit-registers
isaacdevlugt
approved these changes
Jul 18, 2025
mudit2812
approved these changes
Jul 21, 2025
…ature/qubit-registers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: We would like to add support for qubit registers in QASM 3.0.
Description of the Change: Allows qubit registers to be declared, indexed into, and passed to subroutines as well as custom gates.
Benefits: We can now more succinctly express circuits with many qubits.
Possible Drawbacks:
Related ShortCut Story: [sc-94195]