Skip to content

Seminar lens #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevinYitshak wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Seminar lens #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
88599bf
added lens compatibility
kevinYitshak Sep 2, 2022
8910920
edited readme.md file
kevinYitshak Sep 2, 2022
638c977
edited diamond_scene.json
kevinYitshak Sep 2, 2022
5d92662
added reference link in readme.md
kevinYitshak Sep 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,28 @@

![A scene containing diamonds rendered by Ignis with photonmapping](docs/screenshot.jpeg)

## Gallery
## Setting up lens system

Some scenes rendered with Ignis. Acquired from https://benedikt-bitterli.me/resources/ and converted from Mitsuba to our own format. Both images took roughly one minute to render. With an RTX 2080 Super you can even have an interactive view of the scene.
To use lens system, set these two lines in camera section of scene description file:
- use_lens = 1
- lens_element = # size of lens element (int)

Still the lens system is kinda hard coded.
To use different lens system, uncomment the lens configuration in lens.art file and set the number
of lens element accordingly thoughout the lens.art

The implementation is inspired from https://github.com/rod-lin/cs184-final-project/blob/lens-flare/src/lens/lens.cpp
<!-- Some scenes rendered with Ignis. Acquired from https://benedikt-bitterli.me/resources/ and converted from Mitsuba to our own format. Both images took roughly one minute to render. With an RTX 2080 Super you can even have an interactive view of the scene.

![Bedroom scene by SlykDrako](docs/gallery1.jpeg)

![Livingroom scene by Jay-Artist](docs/gallery2.jpeg)

A sample scene from https://github.com/KhronosGroup/glTF-Sample-Models directly rendered within `igview`.

![DragonAttenuation scene by Stanford Scan and Morgan McGuire's Computer Graphics Archive](docs/gallery3.jpeg)
![DragonAttenuation scene by Stanford Scan and Morgan McGuire's Computer Graphics Archive](docs/gallery3.jpeg) -->

![Diamond scene using telephoto lens](docs/cal_telephoto.png)

## Dependencies

Expand Down
Binary file added docs/cal_telephoto.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 2 additions & 0 deletions scenes/diamond_scene.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
},
"camera": {
"type": "perspective",
"use_lens": 1,
"lens_element_size": 7,
"fov": 40,
"near_clip": 0.1,
"far_clip": 100,
Expand Down
Loading