Ajout d'autres universités avec l'intégration d'Appscho #940

Raphitpt · 2025-05-26T17:06:28Z

✨ Nouvelle Pull Request

Merci de contribuer à l'amélioration de Papillon !

Tu te poses des questions sur les pull requests (PR) ? Une documentation a spécialement été créée ici => https://gitbook.getpapillon.xyz/organisation/outils-internes/github

Avant toute chose...

Tu t'assures avoir respecté les points suivants (en rajoutant un x dans les crochets) :

[ x] 📲 J'ai testé l'application via Expo Go et/ou Build et elle fonctionne correctement
[ x] 🗣️ J'utilise le langage informel (tutoiement)
[ x] 📃 Cette PR n'est pas un duplicata et est prête à être review et merge
[ x] ❌ Je n'ai pas fait d'erreurs TypeScript et ESLint dans le code
[ x] 📝 J'ai fait une description des changement effectués ci-dessous

Résumé des changements effectués

J'ai intégré la lib Appscho à l'application. J'ai ajouté un écran avec la liste des diverses instances disponible. Dans les actualité, j'ai ajouté la possibilité d'avoir une image de contenu.
Pour le moment, Appscho ne gère que les EDT et les actualités.

Aussi, il y a divers commit que j'ai revert après, je m'avais un github action pour build mes APKs.

Je reste dispo si besoin

Capture(s) d'écran (pour rendre le test de ta PR rapide)

Le(s) capture(s) d'écran

# Veuillez entrer un message de validation pour expliquer en quoi cette fusion est # nécessaire, surtout si cela fusionne une branche amont mise à jour dans une branche de sujet. # # Les lignes commençant par '#' seront ignorées, et un message vide # abandonne la validation.

raphckrman

Hello ✌

Tout d'abord félicitation, la PR est bonne, le design est respecté c'est très bien intégré, pour la page "Autres universités", serait-il possible de rajouter un champ pour rechercher car sur ton screen il y a l'air d'en avoir pas mal ?

Je t'ai aussi mis quelques commentaires ci-dessous pour changer certaines choses/expliquer du code que j'aurais peut-être mal compris.

PS: Si quelqu'un avec un compte pourrait aussi tester la PR ce serait parfait

raphckrman · 2025-05-26T17:19:00Z

src/services/appscho/data/news.ts

+import { AttachmentType } from "@/services/shared/Attachment";
+import { ErrorServiceUnauthenticated } from "@/services/shared/errors";
+import { getNewsFeed, NewsFeed} from "appscho";
+import {parse} from "date-fns";


Suggested change

import {parse} from "date-fns";

import { parse } from "date-fns";

raphckrman · 2025-05-26T17:19:10Z

src/services/appscho/data/news.ts

@@ -0,0 +1,42 @@
+import {AppschoAccount} from "@/stores/account/types";


Suggested change

import {AppschoAccount} from "@/stores/account/types";

import { AppschoAccount } from "@/stores/account/types";

raphckrman · 2025-05-26T17:21:48Z

src/services/appscho/data/news.ts

+import { Information } from "../../shared/Information";
+import { AttachmentType } from "@/services/shared/Attachment";
+import { ErrorServiceUnauthenticated } from "@/services/shared/errors";
+import { getNewsFeed, NewsFeed} from "appscho";


Suggested change

import { getNewsFeed, NewsFeed} from "appscho";

import { getNewsFeed, NewsFeed } from "appscho";

raphckrman · 2025-05-26T17:22:10Z

src/services/appscho/data/timetable.ts

+  room: c.rooms && Array.isArray(c.rooms) ? c.rooms.join(", ") : (c.rooms || undefined),
+  teacher: c.teachers ? c.teachers.split("\n ").join(", ") : undefined,
+  source: "APPSCHO",
+


Suggested change

raphckrman · 2025-05-26T17:39:16Z

src/services/homework.ts

+      case AccountService.Appscho:
      case AccountService.Local: {
        homeworks = [];
        break;


n'est-il pas préférable de laisser le cas par défaut si ça ne fait rien?

raphckrman · 2025-05-26T17:39:24Z

src/services/homework.ts

+    case AccountService.Appscho:
    case AccountService.Local: {
      break;
    }


raphckrman · 2025-05-26T17:40:28Z

src/views/account/News/Document.tsx

 } from "lucide-react-native";
 import React, { useEffect, useLayoutEffect, useState } from "react";
-import { View, Linking, TouchableOpacity, type GestureResponderEvent, StyleSheet } from "react-native";
+import {View, Linking, TouchableOpacity, type GestureResponderEvent, StyleSheet, Image} from "react-native";


Suggested change

import {View, Linking, TouchableOpacity, type GestureResponderEvent, StyleSheet, Image} from "react-native";

import { View, Linking, TouchableOpacity, type GestureResponderEvent, StyleSheet, Image } from "react-native";

raphckrman · 2025-05-26T17:40:58Z

src/views/login/IdentityProvider/IdentityProviderSelector.tsx

+      name: "appscho",
+      title: "Autres universités",
+      description: "Utilise ton compte CAS pour te connecter",
+      image: require("@/../assets/images/service_appscho.png"), // Envisagez une image plus générique ici


càd une image "plus générique" ?

C'est que avant, j'avais mis un autre logo avant de faire l'icon d'appscho, j'ai oublié d'enlever le com

raphckrman · 2025-05-26T17:43:04Z

src/views/login/IdentityProvider/providers/Appscho.tsx

+          last: account.lastname,
+          first: account.firstname
+        },
+        className: "", // TODO ?


Possible de ne pas mettre "" ou // TODO quand il n'y a rien ? Autant le rajouter plus tard, ça améliore la lisibilité.

raphckrman · 2025-05-26T17:43:36Z

src/views/login/IdentityProvider/providers/AppschoUniversities.tsx

+import {ScrollView} from "react-native-gesture-handler";
+import {NativeItem, NativeList, NativeListHeader, NativeText} from "@/components/Global/NativeComponents";
+import InsetsBottomView from "@/components/Global/InsetsBottomView";
+import {INSTANCES} from "appscho"; // Ajustez le chemin


Suggested change

import {INSTANCES} from "appscho"; // Ajustez le chemin

import { INSTANCES } from "appscho"; // Ajustez le chemin

ajustez le chemin?

Webstorm et ses com

raphckrman · 2025-05-26T17:49:45Z

Possible de fix l'erreur qui empêche ESLint de faire la vérification? (Missing: [email protected] from lock file)

Raphitpt · 2025-05-26T19:49:31Z

D'acc, parfait. Je vais essayer de régler ça mercredi. Si besoin je peux passer mes codes pour tester

Raphitpt · 2025-05-28T16:42:46Z

J'ai corrigé la plupart des threads, j'ai aussi ajouté la recherche sur l'écran d'universités, voir capture. Je reste dispo. Merci à vous les gars 💪

Copilot

Pull Request Overview

This PR adds support for the Appscho identity provider across the login flow and integrates Appscho-based data into several services.

Introduces a searchable AppschoUniversities screen listing available Appscho instances
Implements the Appscho_Login flow, account creation, and secure storage hooks
Hooks Appscho into timetable, news, reload, attendance, and grades services, plus default personalization and profile picture

Reviewed Changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/views/login/IdentityProvider/providers/AppschoUniversities.tsx	Add Appscho university search screen
src/views/login/IdentityProvider/providers/Appscho.tsx	Implement Appscho login and account creation
src/views/login/IdentityProvider/IdentityProviderSelector.tsx	Add Appscho option in selector
src/views/account/News/Document.tsx	Display news image previews
src/utils/ui/default-profile-picture.ts	Provide default Appscho profile picture
src/stores/account/types.ts	Define `AppschoAccount` type and enum
src/services/timetable.ts	Integrate Appscho timetable fetching
src/services/news.ts	Integrate Appscho news fetching
src/services/grades.ts	Stub Appscho for grades features
src/services/attendance.ts	Stub Appscho for attendance features
src/services/appscho/reload-instance.ts	Implement Appscho account reload
src/services/appscho/default-personalization.ts	Set default Appscho personalization
src/services/appscho/data/timetable.ts	Parse Appscho timetable data
src/services/appscho/data/news.ts	Parse Appscho news data
src/router/screens/login/identityProvider.ts	Register Appscho routes
src/router/helpers/types.ts	Add Appscho route parameter types
package.json	Add `appscho` dependency

Comments suppressed due to low confidence (2)

src/views/login/IdentityProvider/providers/Appscho.tsx:27

[nitpick] Variable name local_account is snake_case and inconsistent with camelCase convention. Consider renaming to localAccount.

  const local_account: AppschoAccount = {

src/views/login/IdentityProvider/providers/AppschoUniversities.tsx:14

[nitpick] New screen AppschoUniversities lacks associated unit/integration tests. Adding tests would ensure future changes don't break its search and navigation behavior.

export const AppschoUniversities: Screen<"AppschoUniversities"> = ({ navigation }) => {

src/services/appscho/data/news.ts

src/views/login/IdentityProvider/providers/Appscho.tsx

src/services/appscho/reload-instance.ts

src/views/login/IdentityProvider/providers/Appscho.tsx

Raphitpt and others added 18 commits May 11, 2025 18:09

feat: add appscho service

07d3a36

feat: add all univs

0df26b5

Update start_build.yml debug

7fa9165

Update start_build.yml

bac7547

Update start_build.yml

48a8e7b

Update start_build.yml

bd90f51

Update settings.gradle

40af12f

Update start_build.yml

b1a25b5

Update settings.gradle

9c9eedc

Update start_build.yml

01ad316

Update start_build.yml

f8b02cc

Update start_build.yml

b04a637

Update start_build.yml

1029c60

Merge remote-tracking branch 'origin/univ/appscho' into univ/appscho

3e5d222

fix: if appscho return an error, put timetable to null

d0304c5

fix: if appscho return an error, put timetable to null

3d303d5

Update start_build.yml

d0a91ed

Raphitpt requested a review from Vexcited as a code owner May 26, 2025 17:06

Remove console log

1974a17

raphckrman suggested changes May 26, 2025

View reviewed changes

godetremy requested a review from Copilot May 27, 2025 21:48

This comment was marked as outdated.

Sign in to view

Raphitpt added 3 commits May 28, 2025 16:09

fix: resolve thread

3317184

fix: change default profile picture for appscho

24ab38f

feat: add search on other universities screen

e490908

Raphitpt requested a review from Copilot June 7, 2025 11:01

Raphitpt requested a review from raphckrman June 7, 2025 11:02

Copilot AI reviewed Jun 7, 2025

View reviewed changes

src/services/appscho/data/news.ts Show resolved Hide resolved

src/views/login/IdentityProvider/providers/Appscho.tsx Show resolved Hide resolved

src/services/appscho/reload-instance.ts Show resolved Hide resolved

src/views/login/IdentityProvider/providers/Appscho.tsx Show resolved Hide resolved

Merge branch 'PapillonApp:main' into univ/appscho

147f760

	import {parse} from "date-fns";
	import { parse } from "date-fns";

		@@ -0,0 +1,42 @@
		import {AppschoAccount} from "@/stores/account/types";

	import {AppschoAccount} from "@/stores/account/types";
	import { AppschoAccount } from "@/stores/account/types";

	import { getNewsFeed, NewsFeed} from "appscho";
	import { getNewsFeed, NewsFeed } from "appscho";

	import {View, Linking, TouchableOpacity, type GestureResponderEvent, StyleSheet, Image} from "react-native";
	import { View, Linking, TouchableOpacity, type GestureResponderEvent, StyleSheet, Image } from "react-native";

	import {INSTANCES} from "appscho"; // Ajustez le chemin
	import { INSTANCES } from "appscho"; // Ajustez le chemin

Uh oh!

Ajout d'autres universités avec l'intégration d'Appscho #940

Are you sure you want to change the base?

Ajout d'autres universités avec l'intégration d'Appscho #940

Uh oh!

Conversation

Raphitpt commented May 26, 2025

✨ Nouvelle Pull Request

Avant toute chose...

Résumé des changements effectués

Capture(s) d'écran (pour rendre le test de ta PR rapide)

Uh oh!

raphckrman left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

raphckrman commented May 26, 2025

Uh oh!

Raphitpt commented May 26, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

Raphitpt commented May 28, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

raphckrman left a comment •

edited

Loading