Skip to content

Conversation

@cerus
Copy link

@cerus cerus commented Oct 3, 2025

This resolves #13079. As already noted in the issue comments, the fix is to set attribute_to_user to true in the Wind Burst file.

@cerus cerus requested a review from a team as a code owner October 3, 2025 21:31
@github-project-automation github-project-automation bot moved this to Awaiting review in Paper PR Queue Oct 3, 2025
@electronicboy
Copy link
Member

Changing the vanilla definitions of stuff is pretty precarious as this ends up having a bunch of potential side-effects; the ones in this case seemed quesitonable as to the side-effect; This really should be solved in some other manner

@cerus
Copy link
Author

cerus commented Oct 3, 2025

While I understand your reasoning, I don't see any other clean way of solving this issue without adding questionable code to the explosion logic. If the risks for potential side effects are too high, it might be better to not fix this at all instead of introducing questionable code for this to the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Awaiting review

Development

Successfully merging this pull request may close these issues.

[API Bug] Cancelling EntityPushedByEntityAttackEvent does not stop entities from Wind Burst explosions from being knocked back

2 participants