fix exact choice shapeless recipes #10973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Machine-Maker
added
the
publish-pr
|
Ok, I think this is the best solution. My idea of having a separate map for the "extra" ids being tracked is probably doable, but in a bigger diff for probably not that much gain. Both people who had this issue on the linked issue say this has resolved their problems with custom crafting. |
Machine-Maker
changed the title
|
@Machine-Maker what's the status of delivering that PR? |
kennytv
added
the
priority: high
Machine-Maker
force-pushed
the
fix/exact-choice-shapeless
branch
from
adcf1ae to
01861f0
Compare
kennytv
approved these changes
Jul 17, 2024
Machine-Maker
force-pushed
the
fix/exact-choice-shapeless
branch
from
01861f0 to
7441397
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10971
I still want to see if there's a better fix for this, perhaps separating out it into two
contentsmaps. I also need to test if there's an issue with a stack being regsitered twice, once as it's "simple" id based on the type, and another for it's exact ID.Download the paperclip jar for this pull request: paper-10973.zip