Skip to content

Conversation

@Superjomn
Copy link
Contributor

@Superjomn Superjomn commented Jan 2, 2018

  • scalar sample 100 pointers
  • image will be resized to 80 size
  • bug fix

@Superjomn Superjomn changed the title Feature/support pytorch demo Feature/support some tool demo Jan 2, 2018
@Superjomn Superjomn requested a review from jacquesqiao January 2, 2018 12:57
@jacquesqiao
Copy link
Member

what is tool demo?

mock_data_path = "./mock_data/"

storage = storage.StorageReader(options.logdir)
storage = storage.LogReader(options.logdir)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log_reader is better then storage

}

LOG(INFO) << "scale " << scale;
// LOG(INFO) << "scale " << scale;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rm unused line

Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Superjomn Superjomn merged commit 9444f05 into PaddlePaddle:develop Jan 3, 2018
@Superjomn Superjomn deleted the feature/support_pytorch_demo branch January 3, 2018 08:01
jacquesqiao pushed a commit to jacquesqiao/VisualDL that referenced this pull request Jan 12, 2018
jacquesqiao added a commit to jacquesqiao/VisualDL that referenced this pull request Jan 13, 2018
jacquesqiao pushed a commit to jacquesqiao/VisualDL that referenced this pull request Jan 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants