Skip to content

enhance/fix build.sh #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2018
Merged

enhance/fix build.sh #194

merged 1 commit into from
Jan 21, 2018

Conversation

Superjomn
Copy link
Contributor

  • remove protoc download (quite slow and easy fail)
  • add more dependencies

jacquesqiao
jacquesqiao approved these changes Jan 21, 2018
View reviewed changes
Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Superjomn Superjomn merged commit 8ddc172 into PaddlePaddle:develop Jan 21, 2018
@Superjomn Superjomn deleted the enhance/build_dependency branch January 21, 2018 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daming-lu daming-lu Awaiting requested review from daming-lu

1 more reviewer

@jacquesqiao jacquesqiao jacquesqiao approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Superjomn @jacquesqiao