Skip to content

Conversation

@Superjomn
Copy link
Contributor

No description provided.


sampled_data = []
while data_idx < num_samples:
sampled_data.append(res[len(res) - data_idx - 1])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. len(res)可以存下来使用
  2. 为啥从后往前抽数据最后在逆序?
  3. 不应该如下?
while span_offset < num_samples 

Copy link
Contributor Author

@Superjomn Superjomn Jan 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

逆序保证从最新的数据到最旧的数据

Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Superjomn Superjomn merged commit 971578c into PaddlePaddle:develop Jan 14, 2018
@Superjomn Superjomn deleted the enhance/add_histogram_sample branch January 14, 2018 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants